| commit | 7ffb8574ee4a01fb542470a8d1af977f737432d1 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Mon Dec 04 16:20:50 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Dec 04 16:20:50 2023 +0000 |
| tree | 71d3fb2d6dcc1a85c2ec5033f6641a4eb623fd8f | |
| parent | 44c27644c118208cc7a04d7d57ba951635415e56 [diff] |
[vm] Ensure element type is checked for typed data setRange calls. In c93f924c82, the separate setRange definitions in _TypedIntListMixin, _TypedDoubleListMixin, _Float32x4ListMixin, _Float64x2ListMixin, and _Int32x4ListMixin were replaced with a single definition in _TypedListBase. In doing so, the signature was changed: now the `from` argument is just an Iterable, instead of the more specific Iterable<int>/Iterable<double>/etc in the original definitions. setRange calls two helper methods, _fastSetRange, when from is also a _TypedListBase whose elements are the same size, and _slowSetRange, for all other cases. In _slowSetRange, various casts and checks ensure that the setRange method was called with a compatible element type, but _fastSetRange only checks the _size_ of the element type, not the element type itself, before doing a memory move between the two _TypedListBase objects. That means via upcasting, elements can be copied from an argument with an incompatible element type to the receiver, which would have resulted in a TypeError being thrown before. Change the unified setRange definition to _setRange and recreate the old separate setRange definitions with the more specific signatures, with the separate definitions delegating to _setRange. TEST=vm/dart/regress_53945 Fixes: https://github.com/dart-lang/sdk/issues/53945 Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try,vm-aot-linux-release-x64-try Change-Id: If7eef0b2e07c63aaf776de7b26b1c2cc8c57607d Fixed: 53945 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334201 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.