[dart2wasm] Pass arg counts from JS to Dart as i32
The JS code we generate for converting a Dart function to a function
callable from JS currently looks like this:
_194: f => finalizeWrapper(f, function(x0,x1) {
return dartInstance.exports._194(f,arguments.length,x0,x1)
}),
`_194` called by this JS code is an export:
(func $_194 (;296;) (export "_194")
(param $callback (;0;) anyref)
(param $argumentsLength (;1;) f64)
(param $x1 (;2;) externref)
(param $x2 (;3;) externref)
(result externref)
...)
Here the `double` parameter current causing redundant boxing and slow
`BoxedDouble` operations, because it's compared against an `int` values
when checking whether the right number of arguments is passed to the
Dart function: (in the body of `$_194`, unoptimized)
local.get $argumentsLength
local.set $var5
i32.const 75
local.get $var5
struct.new $BoxedDouble
global.get $global664
call $BoxedDouble.>=
...
We could compare it against double values instead of int to improve
this, but a better way is to make `argumentsLength` an `i32`, as the
argument will always be a small integer (smi), which can be passed
without allocation, so that's what we do in this CL.
The same code with this CL: (unoptimized)
(func $_194 (;294;) (export "_194")
(param $callback (;0;) anyref)
(param $argumentsLengthWasmI32 (;1;) i32)
(param $x1 (;2;) externref)
(param $x2 (;3;) externref)
(result externref)
...
local.get $argumentsLengthWasmI32
i64.extend_i32_s
local.set $argumentsLength
local.get $argumentsLength
i64.const 2
i64.ge_s
...)
Change-Id: Ib9d4d625bea896e8b680e7e5bffc02c19db0d3cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423740
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
https://dart.googlesource.com/sdk/+/6c5d3fb71ffce7cd002ed6530bf98141e62cc3aa
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.