[dart2wasm] Pass arg counts from JS to Dart as i32
The JS code we generate for converting a Dart function to a function
callable from JS currently looks like this:
_194: f => finalizeWrapper(f, function(x0,x1) {
return dartInstance.exports._194(f,arguments.length,x0,x1)
}),
`_194` called by this JS code is an export:
(func $_194 (;296;) (export "_194")
(param $callback (;0;) anyref)
(param $argumentsLength (;1;) f64)
(param $x1 (;2;) externref)
(param $x2 (;3;) externref)
(result externref)
...)
Here the `double` parameter current causing redundant boxing and slow
`BoxedDouble` operations, because it's compared against an `int` values
when checking whether the right number of arguments is passed to the
Dart function: (in the body of `$_194`, unoptimized)
local.get $argumentsLength
local.set $var5
i32.const 75
local.get $var5
struct.new $BoxedDouble
global.get $global664
call $BoxedDouble.>=
...
We could compare it against double values instead of int to improve
this, but a better way is to make `argumentsLength` an `i32`, as the
argument will always be a small integer (smi), which can be passed
without allocation, so that's what we do in this CL.
The same code with this CL: (unoptimized)
(func $_194 (;294;) (export "_194")
(param $callback (;0;) anyref)
(param $argumentsLengthWasmI32 (;1;) i32)
(param $x1 (;2;) externref)
(param $x2 (;3;) externref)
(result externref)
...
local.get $argumentsLengthWasmI32
i64.extend_i32_s
local.set $argumentsLength
local.get $argumentsLength
i64.const 2
i64.ge_s
...)
Change-Id: Ib9d4d625bea896e8b680e7e5bffc02c19db0d3cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423740
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.