Make Zone functions not call `register*`, but properly catch errors. Make `Zone.createTimer`, `Zone.createPeriodicTimer` and `Zone.scheduleMicrotask` not call register on the same zone. These are low-level functions that should not build on top of other low-level functions. Instead the function is registered in the `Timer` constructors and top-level `scheduleMicrotask` code, and the root zone's `createTimer` and `scheduleMicrotask` just make sure that the callback will run in its original zone, and that uncaught errors are handled in the correct zone. Avoids a double-registration that timers did. Significant clean-up. - The private `_Zone`, `_ZoneSpecification` and `_ZoneDelegate` subclasses are not necessary now that their superclasses are `final`. - Stopped using type aliases instead of function types and old-style function arguments. - Renamed some parameters to not be, fx, `f`. Avoided some closure allocations for microtasks by putting the zone into the queue entry, instead of wrapping the callback in a closure calling `zone.run`. This is a potentially visible change if any code uses the zone functions directly and expect them to invoke `Zone.register*`. (Suspiciously no test failed with this change. May need to add some.) Fixes #59913. CoreLibraryReviewExempt: Have had all +1s, just not at the same time. Bug: https://dartbug.com/59913 Change-Id: Ie3c87f5f22aedcbe30ab04718df98e1c0f0659c3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405020 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com> https://dart.googlesource.com/sdk/+/fc2c46ae82cf9c34a7c20bfaecaa759782ba1533
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.