commit fc2c46ae82cf9c34a7c20bfaecaa759782ba1533
author Lasse R.H. Nielsen <lrn@google.com> Thu Jan 30 06:58:51 2025 -0800
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jan 30 06:58:51 2025 -0800
tree f7e506a45ea4451397d71de1ae92d1ed4a664e28
parent f797e5f13841479c4f05e5af1248ef5fe2af673c

Make Zone functions not call `register*`, but properly catch errors.

Make `Zone.createTimer`, `Zone.createPeriodicTimer` and `Zone.scheduleMicrotask`
not call register on the same zone.
These are low-level functions that should not build on top
of other low-level functions.

Instead the function is registered in the `Timer` constructors and
top-level `scheduleMicrotask` code, and the root zone's `createTimer`
and `scheduleMicrotask` just make sure that the callback will run
in its original zone, and that uncaught errors are handled in the
correct zone.
Avoids a double-registration that timers did.

Significant clean-up.
- The private `_Zone`, `_ZoneSpecification` and `_ZoneDelegate`
  subclasses are not necessary now that their superclasses are `final`.
- Stopped using type aliases instead of function types
  and old-style function arguments.
- Renamed some parameters to not be, fx, `f`.

Avoided some closure allocations for microtasks by putting the zone
into the queue entry, instead of wrapping the callback in a closure calling `zone.run`.

This is a potentially visible change if any code uses the zone functions
directly and expect them to invoke `Zone.register*`.
(Suspiciously no test failed with this change. May need to add some.)

Fixes #59913.

CoreLibraryReviewExempt: Have had all +1s, just not at the same time.
Bug: https://dartbug.com/59913
Change-Id: Ie3c87f5f22aedcbe30ab04718df98e1c0f0659c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405020
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>