| commit | 5b827774228e2647b6b698ee59ec30e707b9a3d6 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Fri Mar 22 10:20:48 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Fri Mar 22 03:22:56 2024 -0700 |
| tree | d04a0b4a3ee590f4301c1cac2a7cd5d1f33573b8 | |
| parent | 918e6b06e55ba10a1d7408b383a5eab5ec31201c [diff] |
[vm/ffi] Use untagged pointer representations for FFI pointers. Previously, the FFI used unboxed integers as a native representation for pointers in FFI code, as the compiler only handled very specific uses of untagged pointers flowing between instructions. Since then, this restriction has been removed for untagged pointers that do not point to memory managed by the GC, like FFI pointers, so now they can have a more precise representation. By being precise about when untagged (untagged pointers to freshly allocated Handles and the contents of Pointer data fields) and tagged (TypedData objects constructed to hold the byte representation of compound data) values are expected, we can remove the need to have untagged pointers to GC-movable objects and/or having untagged pointers escape as unboxed integers in the generated IL. This CL also renames kUnboxedFfiIntPtr -> kUnboxedAddress and limits its uses specifically to where the unboxed integer represents the numeric representation of an untagged pointer. This CL changes CCall to take Representations for the arguments and return value instead of what looks like an arbitrary NativeCallingConvention. However, the serializer and deserializers for CCall, used in IL tests, originally assumed that the argument and return representations were kUnboxedFfiIntPtr, so providing an arbitrary NativeCallingConvention which didn't match that assumption would cause failures during IL tests. That assumption came from the fact that the only creator of CCall instructions was in kernel_to_il.cc, and there that was the case. Now CCall builds the native calling convention during construction and deserialization from the argument and return representations and stores both the representations and built native calling convention internally. In the future, if we want to create CCall instructions with more arbitrary native calling conventions, then we'll need to handle serialization/deserialization of arbitrary native calling conventions, and also add consistency checks that the provided representations appropriately match the native calling convention. TEST=ffi vm/dart/regress_306327173_il vm/dart/address_local_pointer_il Issue: https://github.com/dart-lang/sdk/issues/54710 Cq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-release-ia32-try Change-Id: I34effe8fbdc80288b703e0152d5ba67ce2343400 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353101 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com> https://dart.googlesource.com/sdk/+/1cebdcb2da217ca264d2dfb245c081296852b2bf
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.