[dart2wasm] JS interop: use dartify functions specific to types being converted
`dartifyRaw` converts based on the runtime type and it's slow. Use
dartify functions specific to the expected Dart types when converting JS
values to Dart.
Benchmarks before:
WasmJSInterop.call.bool.0Args(RunTimeRaw): 0.023022675490940652 ns.
WasmJSInterop.call.nullableBool.0Args(RunTimeRaw): 0.02189111747851003 ns.
WasmJSInterop.call.num.0Args(RunTimeRaw): 0.028148974752406197 ns.
WasmJSInterop.call.nullableNum.0Args(RunTimeRaw): 0.028181565023670287 ns.
WasmJSInterop.call.double.0Args(RunTimeRaw): 0.022986874778290176 ns.
WasmJSInterop.call.nullableDouble.0Args(RunTimeRaw): 0.02907384054925038 ns.
WasmJSInterop.call.int.0Args(RunTimeRaw): 0.029822888283378746 ns.
WasmJSInterop.call.nullableInt.0Args(RunTimeRaw): 0.029088963619688168 ns.
WasmJSInterop.call.string.0Args(RunTimeRaw): 0.020517746991606835 ns.
WasmJSInterop.call.nullableString.0Args(RunTimeRaw): 0.02004299314157027 ns.
WasmJSInterop.call.JSArray.0Args(RunTimeRaw): 0.020724174653887113 ns.
WasmJSInterop.call.nullableJSArray.0Args(RunTimeRaw): 0.020034212115113702 ns.
WasmJSInterop.call.JSUint8Array.0Args(RunTimeRaw): 0.030711090544501003 ns.
WasmJSInterop.call.nullableJSUint8Array.0Args(RunTimeRaw): 0.030679086538461537 ns.
Benchmarks after:
WasmJSInterop.call.bool.0Args(RunTimeRaw): 0.019944312674022892 ns.
WasmJSInterop.call.nullableBool.0Args(RunTimeRaw): 0.0206124732933157 ns.
WasmJSInterop.call.num.0Args(RunTimeRaw): 0.024475179056557175 ns.
WasmJSInterop.call.nullableNum.0Args(RunTimeRaw): 0.02481147236988503 ns.
WasmJSInterop.call.double.0Args(RunTimeRaw): 0.01829122645842903 ns.
WasmJSInterop.call.nullableDouble.0Args(RunTimeRaw): 0.024581756014165346 ns.
WasmJSInterop.call.int.0Args(RunTimeRaw): 0.01788861473387381 ns.
WasmJSInterop.call.nullableInt.0Args(RunTimeRaw): 0.02333933933933934 ns.
WasmJSInterop.call.string.0Args(RunTimeRaw): 0.018238532110091743 ns.
WasmJSInterop.call.nullableString.0Args(RunTimeRaw): 0.019454117647058823 ns.
WasmJSInterop.call.JSArray.0Args(RunTimeRaw): 0.020055434567412395 ns.
WasmJSInterop.call.nullableJSArray.0Args(RunTimeRaw): 0.019759825327510916 ns.
WasmJSInterop.call.JSUint8Array.0Args(RunTimeRaw): 0.030023959269242288 ns.
WasmJSInterop.call.nullableJSUint8Array.0Args(RunTimeRaw): 0.03057233704292528 ns.
JSValue wrapper type performance (`JSUint8Array`, `JSArray`) does not
change as we had a special case (before this CL) for those types and
directly boxed them.
Issue: https://github.com/dart-lang/sdk/issues/60357
Change-Id: I0ee8e49cf3ed801634e4c6e13b1c597b2e730d59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424021
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
https://dart.googlesource.com/sdk/+/273ae8767920a92c2eedc486bb0dd72d60401cd3
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.