Google Git
Sign in
dart / sdk / 273ae8767920a92c2eedc486bb0dd72d60401cd3
commit273ae8767920a92c2eedc486bb0dd72d60401cd3[log] [tgz]
authorÖmer Ağacan <omersa@google.com>Wed May 21 04:39:30 2025 -0700
committerCommit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 21 04:39:30 2025 -0700
treead3e882e52030fb0955f3254f96047f36b6f5994
parentbbb847eb71af2e7de58c26afca40029547e3d2a4 [diff]
[dart2wasm] JS interop: use dartify functions specific to types being converted

`dartifyRaw` converts based on the runtime type and it's slow. Use
dartify functions specific to the expected Dart types when converting JS
values to Dart.

Benchmarks before:

    WasmJSInterop.call.bool.0Args(RunTimeRaw): 0.023022675490940652 ns.
    WasmJSInterop.call.nullableBool.0Args(RunTimeRaw): 0.02189111747851003 ns.
    WasmJSInterop.call.num.0Args(RunTimeRaw): 0.028148974752406197 ns.
    WasmJSInterop.call.nullableNum.0Args(RunTimeRaw): 0.028181565023670287 ns.
    WasmJSInterop.call.double.0Args(RunTimeRaw): 0.022986874778290176 ns.
    WasmJSInterop.call.nullableDouble.0Args(RunTimeRaw): 0.02907384054925038 ns.
    WasmJSInterop.call.int.0Args(RunTimeRaw): 0.029822888283378746 ns.
    WasmJSInterop.call.nullableInt.0Args(RunTimeRaw): 0.029088963619688168 ns.
    WasmJSInterop.call.string.0Args(RunTimeRaw): 0.020517746991606835 ns.
    WasmJSInterop.call.nullableString.0Args(RunTimeRaw): 0.02004299314157027 ns.
    WasmJSInterop.call.JSArray.0Args(RunTimeRaw): 0.020724174653887113 ns.
    WasmJSInterop.call.nullableJSArray.0Args(RunTimeRaw): 0.020034212115113702 ns.
    WasmJSInterop.call.JSUint8Array.0Args(RunTimeRaw): 0.030711090544501003 ns.
    WasmJSInterop.call.nullableJSUint8Array.0Args(RunTimeRaw): 0.030679086538461537 ns.

Benchmarks after:

    WasmJSInterop.call.bool.0Args(RunTimeRaw): 0.019944312674022892 ns.
    WasmJSInterop.call.nullableBool.0Args(RunTimeRaw): 0.0206124732933157 ns.
    WasmJSInterop.call.num.0Args(RunTimeRaw): 0.024475179056557175 ns.
    WasmJSInterop.call.nullableNum.0Args(RunTimeRaw): 0.02481147236988503 ns.
    WasmJSInterop.call.double.0Args(RunTimeRaw): 0.01829122645842903 ns.
    WasmJSInterop.call.nullableDouble.0Args(RunTimeRaw): 0.024581756014165346 ns.
    WasmJSInterop.call.int.0Args(RunTimeRaw): 0.01788861473387381 ns.
    WasmJSInterop.call.nullableInt.0Args(RunTimeRaw): 0.02333933933933934 ns.
    WasmJSInterop.call.string.0Args(RunTimeRaw): 0.018238532110091743 ns.
    WasmJSInterop.call.nullableString.0Args(RunTimeRaw): 0.019454117647058823 ns.
    WasmJSInterop.call.JSArray.0Args(RunTimeRaw): 0.020055434567412395 ns.
    WasmJSInterop.call.nullableJSArray.0Args(RunTimeRaw): 0.019759825327510916 ns.
    WasmJSInterop.call.JSUint8Array.0Args(RunTimeRaw): 0.030023959269242288 ns.
    WasmJSInterop.call.nullableJSUint8Array.0Args(RunTimeRaw): 0.03057233704292528 ns.

JSValue wrapper type performance (`JSUint8Array`, `JSArray`) does not
change as we had a special case (before this CL) for those types and
directly boxed them.

Issue: https://github.com/dart-lang/sdk/issues/60357
Change-Id: I0ee8e49cf3ed801634e4c6e13b1c597b2e730d59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424021
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
4 files changed
tree: ad3e882e52030fb0955f3254f96047f36b6f5994
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. sdk/
  10. tests/
  11. third_party/
  12. tools/
  13. utils/
  14. .clang-format
  15. .gitattributes
  16. .gitconfig
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .style.yapf
  21. AUTHORS
  22. BUILD.gn
  23. CHANGELOG.md
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. OWNERS
  29. PATENT_GRANT
  30. PRESUBMIT.py
  31. pubspec.yaml
  32. README.dart-sdk
  33. README.md
  34. sdk.code-workspace
  35. sdk_args.gni
  36. sdk_packages.yaml
  37. SECURITY.md
  38. WATCHLISTS
README.md

Dart

An approachable, portable, and productive language for high-quality apps on any platform

Dart is:

  • Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.

  • Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents in our repo at docs.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.

Roadmap

Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.