| commit | 41fe5c1da298791e7a80950cbd5ad44c7cee2559 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Mon May 12 08:25:20 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon May 12 08:37:12 2025 -0700 |
| tree | 788ea4ae15c4b8f90d80e5bfdd6d9f35bd8a46e7 | |
| parent | 16ce2acb33770a1112cffe3fb21a318435204a0b [diff] |
[flow analysis] Allow non-cascaded field accesses to participate in field promotion. The way this is accomplished is that in `_FlowAnalysisImpl.nullAwareAccess_rightBegin`, any expression reference associated with the target of the null-aware access is restored, and the corresponding SSA node is associated with the guard variable (if any). These changes ensure that if the null-aware access is a property get, the subsequent call to `propertyGet` will pick up the appropriate SSA node, so it will be able to locate the promotion key for the property. This functionality is only enabled when the language feature `sound-flow-analysis` is enabled. To prevent test regressions, a few related changes need to be made at the same time: - `_FlowAnalysisImpl.nullAwareAccess_end` is changed so that it clears any expression info or expression reference that was associated with the null-aware access expression. This prevents flow analysis information from being erroneously propagated out of a null-aware expression, which would have led to assertion failures when analyzing null-aware expressions inside of conditional expressions. This wasn't previously a problem because the expression reference used to be consumed by `_FlowAnalysisImpl.nullAwareAccess_rightBegin`, preventing further expression references and expression infos from being recorded further along in the null-aware access. - The test framework in `mini_ast.dart` is fixed so that `!` is considered to participate in null shorting. This was a bug in the test framework that wasn't previously caught because it happened not to produce any test failures. - The analyzer's method `PostfixExpressionResolver._resolveNullCheck` is changed so that it calls `nonNullAssert_end` before terminating null-aware access. Previously, the order was swapped, causing `nullAwareAccess_end` to be called before `nonNullAssert_end` when analyzing expressions like `a?.b!`. This used to be benign, but now that non-cascaded field accesses participate in field promotion, flow analysis needs the methods to be called in the correct order. Fixes https://github.com/dart-lang/language/issues/4344. Bug: https://github.com/dart-lang/language/issues/4344 Change-Id: I523be1b4be1af3f68654a745187a546728c878fe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427820 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> https://dart.googlesource.com/sdk/+/7436b97ba432dd83f8efd741d2c56317656bf9c7
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.