| commit | 7436b97ba432dd83f8efd741d2c56317656bf9c7 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Mon May 12 08:25:20 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 12 08:25:20 2025 -0700 |
| tree | 6f007d0c0d131b94cca880ad167cf6cd6ed47a0e | |
| parent | 6d62d9ae38e64f05ad448a212deb82f878342f4c [diff] |
[flow analysis] Allow non-cascaded field accesses to participate in field promotion. The way this is accomplished is that in `_FlowAnalysisImpl.nullAwareAccess_rightBegin`, any expression reference associated with the target of the null-aware access is restored, and the corresponding SSA node is associated with the guard variable (if any). These changes ensure that if the null-aware access is a property get, the subsequent call to `propertyGet` will pick up the appropriate SSA node, so it will be able to locate the promotion key for the property. This functionality is only enabled when the language feature `sound-flow-analysis` is enabled. To prevent test regressions, a few related changes need to be made at the same time: - `_FlowAnalysisImpl.nullAwareAccess_end` is changed so that it clears any expression info or expression reference that was associated with the null-aware access expression. This prevents flow analysis information from being erroneously propagated out of a null-aware expression, which would have led to assertion failures when analyzing null-aware expressions inside of conditional expressions. This wasn't previously a problem because the expression reference used to be consumed by `_FlowAnalysisImpl.nullAwareAccess_rightBegin`, preventing further expression references and expression infos from being recorded further along in the null-aware access. - The test framework in `mini_ast.dart` is fixed so that `!` is considered to participate in null shorting. This was a bug in the test framework that wasn't previously caught because it happened not to produce any test failures. - The analyzer's method `PostfixExpressionResolver._resolveNullCheck` is changed so that it calls `nonNullAssert_end` before terminating null-aware access. Previously, the order was swapped, causing `nullAwareAccess_end` to be called before `nonNullAssert_end` when analyzing expressions like `a?.b!`. This used to be benign, but now that non-cascaded field accesses participate in field promotion, flow analysis needs the methods to be called in the correct order. Fixes https://github.com/dart-lang/language/issues/4344. Bug: https://github.com/dart-lang/language/issues/4344 Change-Id: I523be1b4be1af3f68654a745187a546728c878fe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427820 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.