[web] delete file_sample_api_test - a flaky and obsolete test. This test has non-deterministic failures (rate 30% on mac, 10% on linux and windows) caused likely by a data-race ([example log][1]). The test has a write to set the contents of a file, and a corresponding read. The error makes it appear as if the read occurred before the write completed. This API is part of the [createWriter][2] proposal, which was abandoned early on (almost a decade ago) and documented as deprecated. As a result I believe this test is providing coverage for obsolete functionality. In fact, the API for the `write` returns void and appears synchronous, but my guess is that it is not. There is no API to ensure the write completes as far as I know. An alternative here would be to use timers to add a significant delay between the operations. It is also worth noting that the [requestFileSystem][3] API to access the FileSystem (used here and in the fileapi tests) is also deprecated and not supported in firefox or safari. Given the flakiness issue and the fact that this API is already deprecated, I'm not really seeing the value in keeping the test. [1]: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8767600632278735009/+/u/test_results/ignored_flaky_test_failure_logs [2]: https://developer.mozilla.org/en-US/docs/Web/API/FileSystemFileEntry/createWriter [3]: https://developer.mozilla.org/en-US/docs/Web/API/Window/requestFileSystem Change-Id: I92ad6399218c6a17cfa029a99b99afcfadde0035 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332282 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> https://dart.googlesource.com/sdk/+/8f4d4391e10bd3a03c25517dd3965e992556c196
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.