| commit | 1e3b92d8ab80f792671e68703fe2615875b94e5d | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Tue Apr 01 10:38:50 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Tue Apr 01 10:40:02 2025 -0700 |
| tree | 2604e9899c4e07d323c43ad8a11cc5ccb9232f85 | |
| parent | 809ffe2f681e209308dd76d370e7b6000e9e4177 [diff] |
[analyzer] Lock down the behavior of `ResultComparator` with unit tests. In a follow-up CL, I intend to rewrite `ResultComparator` in a way that doesn't depend on its base class, `AstComparator` (so that `AstComparator` can be deleted). This change prepares for the rewrite by adding unit tests for `ResultComparator`. I've discovered some bugs in `ResultComparator` in the process: - The failure messages reported when one of the two nodes was `null` were reversed. I've gone ahead and fixed this as part of this CL, since the fix was easy and didn't affect any tests beyond the tests that I've added. - The failure message reported when a node had the wrong type contained an unnecessary newline. I've gone ahead and fixed this as part of this CL, since the fix was easy and didn't affect any tests beyond the tests that I've added. - When comparing identifiers, if the actual identifier is a synthetic identifier, and the expected identifier is any identifier at all, the identifiers are considered to match. This is clearly not the intended behavior; the intended behavior is that the expected identifier must be `_s_` to match a synthetic identifier. I've documented this bug with a TODO, which I'll address in a follow-up CL. - When comparing comments, only the references inside the comment are compared; the text of the comment is ignored. This seems inconsistent with the other behaviors of `ResultComparator`, and I'm pretty sure it's not necessary. I've documented this bug with a TODO, which I'll address in a follow-up CL. Change-Id: Iba0169ded812d646b71966c2be22174d787c5a21 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419424 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/d7fa12fbe287b9a3cbc649c71fa78dbb811e292f
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.