[analyzer] Lock down the behavior of `ResultComparator` with unit tests.

In a follow-up CL, I intend to rewrite `ResultComparator` in a way
that doesn't depend on its base class, `AstComparator` (so that
`AstComparator` can be deleted). This change prepares for the rewrite
by adding unit tests for `ResultComparator`.

I've discovered some bugs in `ResultComparator` in the process:

- The failure messages reported when one of the two nodes was `null`
  were reversed. I've gone ahead and fixed this as part of this CL,
  since the fix was easy and didn't affect any tests beyond the tests
  that I've added.

- The failure message reported when a node had the wrong type
  contained an unnecessary newline. I've gone ahead and fixed this as
  part of this CL, since the fix was easy and didn't affect any tests
  beyond the tests that I've added.

- When comparing identifiers, if the actual identifier is a synthetic
  identifier, and the expected identifier is any identifier at all,
  the identifiers are considered to match. This is clearly not the
  intended behavior; the intended behavior is that the expected
  identifier must be `_s_` to match a synthetic identifier. I've
  documented this bug with a TODO, which I'll address in a follow-up
  CL.

- When comparing comments, only the references inside the comment are
  compared; the text of the comment is ignored. This seems
  inconsistent with the other behaviors of `ResultComparator`, and I'm
  pretty sure it's not necessary. I've documented this bug with a
  TODO, which I'll address in a follow-up CL.

Change-Id: Iba0169ded812d646b71966c2be22174d787c5a21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419424
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
3 files changed
tree: 66c6feb4aa6e2a68ac635e1431c15c6a7561f990
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. sdk/
  10. tests/
  11. third_party/
  12. tools/
  13. utils/
  14. .clang-format
  15. .gitattributes
  16. .gitconfig
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .style.yapf
  21. AUTHORS
  22. BUILD.gn
  23. CHANGELOG.md
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. OWNERS
  29. PATENT_GRANT
  30. PRESUBMIT.py
  31. pubspec.yaml
  32. README.dart-sdk
  33. README.md
  34. sdk.code-workspace
  35. sdk_args.gni
  36. sdk_packages.yaml
  37. SECURITY.md
  38. WATCHLISTS
README.md

Dart

An approachable, portable, and productive language for high-quality apps on any platform

Dart is:

  • Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.

  • Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents in our repo at docs.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.

Roadmap

Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.