commit c7566734f90f1f262a7f51e6246c3579c75e484d
author Kevin Moore <kevmoo@users.noreply.github.com> Tue Oct 23 07:36:47 2018 -0700
committer GitHub <noreply@github.com> Tue Oct 23 07:36:47 2018 -0700
tree 649e9726092aea87e9268cbf44dadb2f33e8da8a
parent 4da4a46ad88c70f539bcfe98edb866b292afd08e

enable pedantic lints (#167)

analysis_options.yaml

diff --git a/analysis_options.yaml b/analysis_options.yaml
index 02a06ee..d7cb8a2 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -1,3 +1,4 @@
+include: package:pedantic/analysis_options.yaml
 analyzer:
   strong-mode:
     implicit-casts: false

lib/src/invocation_matcher.dart

diff --git a/lib/src/invocation_matcher.dart b/lib/src/invocation_matcher.dart
index 085ab79..9fc9d81 100644
--- a/lib/src/invocation_matcher.dart
+++ b/lib/src/invocation_matcher.dart
@@ -33,10 +33,10 @@
 /// what a user expects to be called.
 Matcher invokes(
   Symbol memberName, {
-  List<dynamic> positionalArguments: const [],
-  Map<Symbol, dynamic> namedArguments: const {},
-  bool isGetter: false,
-  bool isSetter: false,
+  List<dynamic> positionalArguments = const [],
+  Map<Symbol, dynamic> namedArguments = const {},
+  bool isGetter = false,
+  bool isSetter = false,
 }) {
   if (isGetter && isSetter) {
     throw new ArgumentError('Cannot set isGetter and iSetter');
@@ -80,10 +80,10 @@
 
   _InvocationSignature({
     @required this.memberName,
-    this.positionalArguments: const [],
-    this.namedArguments: const {},
-    this.isGetter: false,
-    this.isSetter: false,
+    this.positionalArguments = const [],
+    this.namedArguments = const {},
+    this.isGetter = false,
+    this.isSetter = false,
   });
 
   @override

pubspec.yaml

diff --git a/pubspec.yaml b/pubspec.yaml
index 6af1ddf..b7e2307 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -9,7 +9,7 @@
 homepage: https://github.com/dart-lang/mockito
 
 environment:
-  sdk: '>=2.0.0-dev.16.0 <3.0.0'
+  sdk: '>=2.0.0 <3.0.0'
 
 dependencies:
   collection: ^1.1.0
@@ -21,3 +21,4 @@
   build_runner: ^1.0.0
   build_test: ^0.10.0
   build_web_compilers: ^0.4.0
+  pedantic: ^1.3.0

test/deprecated_apis/mockito_test.dart

diff --git a/test/deprecated_apis/mockito_test.dart b/test/deprecated_apis/mockito_test.dart
index 2091b9f..e14cfdc 100644
--- a/test/deprecated_apis/mockito_test.dart
+++ b/test/deprecated_apis/mockito_test.dart
@@ -60,7 +60,7 @@
     fail("It was expected to fail!");
   } catch (e) {
     if (!(e is TestFailure)) {
-      throw e;
+      rethrow;
     } else {
       if (expectedMessage != e.message) {
         throw new TestFailure("Failed, but with wrong message: ${e.message}");

test/deprecated_apis/verify_test.dart

diff --git a/test/deprecated_apis/verify_test.dart b/test/deprecated_apis/verify_test.dart
index 219bc31..abb5b7e 100644
--- a/test/deprecated_apis/verify_test.dart
+++ b/test/deprecated_apis/verify_test.dart
@@ -63,7 +63,7 @@
     fail('It was expected to fail!');
   } catch (e) {
     if (!(e is TestFailure)) {
-      throw e;
+      rethrow;
     } else {
       if (expectedMessage != e.message) {
         throw new TestFailure('Failed, but with wrong message: ${e.message}');

test/mockito_test.dart

diff --git a/test/mockito_test.dart b/test/mockito_test.dart
index 3369522..4c2765e 100644
--- a/test/mockito_test.dart
+++ b/test/mockito_test.dart
@@ -56,7 +56,7 @@
     fail("It was expected to fail!");
   } catch (e) {
     if (!(e is TestFailure)) {
-      throw e;
+      rethrow;
     } else {
       if (expectedMessage != e.message) {
         throw new TestFailure("Failed, but with wrong message: ${e.message}");