Enable and fix latest pedantic lints
diff --git a/analysis_options.yaml b/analysis_options.yaml
index bcff04b..246b080 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -1,3 +1,4 @@
+include: package:pedantic/analysis_options.yaml
analyzer:
errors:
dead_code: error
diff --git a/lib/src/core_matchers.dart b/lib/src/core_matchers.dart
index 73570e3..86bb1db 100644
--- a/lib/src/core_matchers.dart
+++ b/lib/src/core_matchers.dart
@@ -163,7 +163,7 @@
class _HasLength extends Matcher {
final Matcher _matcher;
- const _HasLength([Matcher matcher]) : this._matcher = matcher;
+ const _HasLength([Matcher matcher]) : _matcher = matcher;
bool matches(item, Map matchState) {
try {
diff --git a/lib/src/custom_matcher.dart b/lib/src/custom_matcher.dart
index 43ccaa9..c3c7270 100644
--- a/lib/src/custom_matcher.dart
+++ b/lib/src/custom_matcher.dart
@@ -36,7 +36,7 @@
final Matcher _matcher;
CustomMatcher(this._featureDescription, this._featureName, matcher)
- : this._matcher = wrapMatcher(matcher);
+ : _matcher = wrapMatcher(matcher);
/// Override this to extract the interesting feature.
Object featureValueOf(actual) => actual;
diff --git a/lib/src/equals_matcher.dart b/lib/src/equals_matcher.dart
index 31e369b..52f6688 100644
--- a/lib/src/equals_matcher.dart
+++ b/lib/src/equals_matcher.dart
@@ -97,7 +97,7 @@
final Object _expected;
final int _limit;
- _DeepMatcher(this._expected, [int limit = 1000]) : this._limit = limit;
+ _DeepMatcher(this._expected, [int limit = 1000]) : _limit = limit;
// Returns a pair (reason, location)
List<String> _compareIterables(Iterable expected, Object actual,
diff --git a/lib/src/having_matcher.dart b/lib/src/having_matcher.dart
index 1684a93..8ca98c6 100644
--- a/lib/src/having_matcher.dart
+++ b/lib/src/having_matcher.dart
@@ -16,8 +16,8 @@
HavingMatcher(TypeMatcher<T> parent, String description,
Object feature(T source), Object matcher,
[Iterable<_FunctionMatcher> existing])
- : this._parent = parent,
- this._functionMatchers = <_FunctionMatcher>[]
+ : _parent = parent,
+ _functionMatchers = <_FunctionMatcher>[]
..addAll(existing ?? [])
..add(new _FunctionMatcher<T>(description, feature, matcher));
diff --git a/lib/src/order_matchers.dart b/lib/src/order_matchers.dart
index 829aadb..a62ffb9 100644
--- a/lib/src/order_matchers.dart
+++ b/lib/src/order_matchers.dart
@@ -72,7 +72,7 @@
const _OrderingMatcher(this._value, this._equalValue, this._lessThanValue,
this._greaterThanValue, this._comparisonDescription,
[bool valueInDescription = true])
- : this._valueInDescription = valueInDescription;
+ : _valueInDescription = valueInDescription;
bool matches(item, Map matchState) {
if (item == _value) {
diff --git a/lib/src/type_matcher.dart b/lib/src/type_matcher.dart
index 91552c9..1f2db26 100644
--- a/lib/src/type_matcher.dart
+++ b/lib/src/type_matcher.dart
@@ -47,7 +47,7 @@
[@Deprecated('Provide a type argument to TypeMatcher and omit the name. '
'This argument will be removed in the next release.')
String name])
- : this._name =
+ : _name =
// ignore: deprecated_member_use
name;
diff --git a/pubspec.yaml b/pubspec.yaml
index 5250a12..7c598b9 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -12,6 +12,7 @@
stack_trace: ^1.2.0
dev_dependencies:
+ pedantic: ^1.4.0
test: '>=0.12.0 <2.0.0'
dependency_overrides:
