blob: 2fd78a1157cfa859fcfeb8614cb28c6cfc26dcf9 [file] [log] [blame]
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:linter/src/analyzer.dart';
const _desc = r'Put @required named parameters first.';
const _details = r'''
**DO** specify `@required` on named parameter before other named parameters.
**GOOD:**
```
m({@required a, b, c}) ;
```
**BAD:**
```
m({b, c, @required a}) ;
```
''';
class AlwaysPutRequiredNamedParametersFirst extends LintRule
implements NodeLintRule {
AlwaysPutRequiredNamedParametersFirst()
: super(
name: 'always_put_required_named_parameters_first',
description: _desc,
details: _details,
group: Group.style);
@override
void registerNodeProcessors(NodeLintRegistry registry,
[LinterContext context]) {
final visitor = new _Visitor(this);
registry.addFormalParameterList(this, visitor);
}
}
class _Visitor extends SimpleAstVisitor<void> {
final LintRule rule;
_Visitor(this.rule);
@override
void visitFormalParameterList(FormalParameterList node) {
bool nonRequiredSeen = false;
for (DefaultFormalParameter param
in node.parameters.where((p) => p.isNamed)) {
if (param.declaredElement.hasRequired) {
if (nonRequiredSeen) {
rule.reportLintForToken(param.identifier.token);
}
} else {
nonRequiredSeen = true;
}
}
}
}