blob: 1410983575946f3b298e8b4f9ab21ce121a6bf3c [file] [log] [blame]
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
import 'package:analyzer/dart/element/element.dart';
import '../analyzer.dart';
import '../ast.dart';
import '../util/flutter_utils.dart';
const _desc = r'Avoid `print` calls in production code.';
const _details = r'''
**DO** avoid `print` calls in production code.
For production code, consider using a logging framework.
If you are using Flutter, you can use `debugPrint`
or surround `print` calls with a check for `kDebugMode`
**BAD:**
```dart
void f(int x) {
print('debug: $x');
...
}
```
**GOOD:**
```dart
void f(int x) {
debugPrint('debug: $x');
...
}
```
**GOOD:**
```dart
void f(int x) {
log('log: $x');
...
}
```
**GOOD:**
```dart
void f(int x) {
if (kDebugMode) {
print('debug: $x');
}
...
}
```
''';
class AvoidPrint extends LintRule {
static const LintCode code = LintCode(
'avoid_print', "Don't invoke 'print' in production code.",
correctionMessage: 'Try using a logging framework.');
AvoidPrint()
: super(
name: 'avoid_print',
description: _desc,
details: _details,
group: Group.errors);
@override
LintCode get lintCode => code;
@override
void registerNodeProcessors(
NodeLintRegistry registry, LinterContext context) {
var visitor = _Visitor(this);
registry.addMethodInvocation(this, visitor);
}
}
class _Visitor extends SimpleAstVisitor {
final LintRule rule;
_Visitor(this.rule);
@override
void visitMethodInvocation(MethodInvocation node) {
if (node.methodName.staticElement.isDartCorePrint && !_isDebugOnly(node)) {
rule.reportLint(node.methodName);
}
node.argumentList.arguments.forEach(_validateArgument);
}
bool _isDebugOnly(Expression expression) {
AstNode? node = expression;
while (node != null) {
var parent = node.parent;
if (parent is IfStatement && node == parent.thenStatement) {
var condition = parent.condition;
if (condition is SimpleIdentifier &&
isKDebugMode(condition.staticElement)) {
return true;
}
} else if (parent is FunctionBody) {
return false;
}
node = parent;
}
return false;
}
void _validateArgument(Expression expression) {
if (expression is SimpleIdentifier) {
var element = expression.staticElement;
if (element is FunctionElement &&
element.name == 'print' &&
element.library.isDartCore) {
rule.reportLint(expression);
}
}
}
}