Report use_setters_to_change_properties on the method name (#2719)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa8b9f0..6beb018 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# master
+
+- update `use_setters_to_change_properties` to only highlight a method name,
+ not the entire body and doc comment.
+
# 1.6.1
- reverted relaxation of `sort_child_properties_last` to allow for a
diff --git a/lib/src/rules/use_setters_to_change_properties.dart b/lib/src/rules/use_setters_to_change_properties.dart
index 6f724d1..ef865e0 100644
--- a/lib/src/rules/use_setters_to_change_properties.dart
+++ b/lib/src/rules/use_setters_to_change_properties.dart
@@ -61,7 +61,8 @@
node.returnType?.type?.isVoid != true) {
return;
}
- void _visitExpression(Expression expression) {
+
+ void checkExpression(Expression expression) {
if (expression is AssignmentExpression &&
expression.operator.type == TokenType.EQ) {
var leftOperand =
@@ -70,7 +71,7 @@
expression.rightHandSide);
var parameterElement = node.declaredElement?.parameters.first;
if (rightOperand == parameterElement && leftOperand is FieldElement) {
- rule.reportLint(node);
+ rule.reportLint(node.name);
}
}
}
@@ -80,11 +81,11 @@
if (body.block.statements.length == 1) {
var statement = body.block.statements.first;
if (statement is ExpressionStatement) {
- _visitExpression(statement.expression);
+ checkExpression(statement.expression);
}
}
} else if (body is ExpressionFunctionBody) {
- _visitExpression(body.expression);
+ checkExpression(body.expression);
}
}
}
