remove effective dart ruleset references (#2963)
diff --git a/README.md b/README.md
index 24a435a..889cd9c 100644
--- a/README.md
+++ b/README.md
@@ -34,11 +34,11 @@
$ dart analyze .
-and see any violations of the `annotate_overrides`, `hash_and_equals`, and `prefer_is_not_empty` rules in the console. To help you choose
-the rules you want to enable for your package, we have provided a [complete list of rules][lints] with lints recommended by the Dart team
-collected in [`package:lints`][package-dart-lints]. For the lints that are enforced internally at Google, see [`package:pedantic`][package-pedantic].
-For a set of rules corresponding to the [Effective Dart][effective_dart] guide, see [`package:effective_dart`][package-effective-dart]. Lints
-recommended for Flutter apps, packages, and plugins are documented in [`package:flutter_lints`][package-flutter-lints].
+and see any violations of the `annotate_overrides`, `hash_and_equals`, and `prefer_is_not_empty` rules in the console.
+To help you choose the rules you want to enable for your package, we have provided a [complete list of rules][lints]
+with lints recommended by the Dart team collected in [`package:lints`][package-dart-lints]. For the lints that are
+enforced internally at Google, see [`package:pedantic`][package-pedantic]. Lints recommended for Flutter apps, packages,
+and plugins are documented in [`package:flutter_lints`][package-flutter-lints].
If a specific lint warning should be ignored, it can be flagged with a comment. For example,
@@ -95,7 +95,6 @@
[effective_dart]:https://dart.dev/guides/language/effective-dart
[lints]: https://dart-lang.github.io/linter/lints/
[options_file]: https://dart.dev/guides/language/analysis-options#the-analysis-options-file
-[package-effective-dart]: https://github.com/tenhobi/effective_dart
[package-dart-lints]: https://github.com/dart-lang/lints
[package-flutter-lints]: https://github.com/flutter/packages/tree/master/packages/flutter_lints
[package-pedantic]: https://github.com/dart-lang/pedantic/blob/master/lib/analysis_options.yaml
diff --git a/tool/crawl.dart b/tool/crawl.dart
index 81ae4e8..a4245dd 100644
--- a/tool/crawl.dart
+++ b/tool/crawl.dart
@@ -22,11 +22,6 @@
final Version bottomDartSdk = Version(2, 0, 0);
Map<String, String?> _dartSdkToLinterMap = <String, String?>{};
-final _effectiveDartOptionsRootUrl = Uri.https(
- 'raw.githubusercontent.com', '/tenhobi/effective_dart/master/lib/');
-final _effectiveDartOptionsUrl =
- _effectiveDartOptionsRootUrl.resolve('analysis_options.yaml');
-List<String>? _effectiveDartRules;
final _flutterOptionsUrl = Uri.https('raw.githubusercontent.com',
'/flutter/packages/master/packages/flutter_lints/lib/flutter.yaml');
final _flutterRepoOptionsUrl = Uri.https('raw.githubusercontent.com',
@@ -52,9 +47,6 @@
List<String>? _stagehandRules;
-Future<List<String>> get effectiveDartRules async =>
- _effectiveDartRules ??= await _fetchEffectiveDartRules();
-
Future<List<String>> get flutterRepoRules async =>
_flutterRepoRules ??= await score_utils.fetchRules(_flutterRepoOptionsUrl);
@@ -159,15 +151,6 @@
return req.body;
}
-Future<List<String>> _fetchEffectiveDartRules() async {
- var client = http.Client();
- var req = await client.get(_effectiveDartOptionsUrl);
- var includedOptions =
- req.body.split('include: package:effective_dart/')[1].trim();
- return score_utils
- .fetchRules(_effectiveDartOptionsRootUrl.resolve(includedOptions));
-}
-
Future<String?> _fetchLinterForVersion(String version) async {
var deps = await _fetchDEPSforVersion(version);
for (var line in deps.split('\n')) {
diff --git a/tool/doc.dart b/tool/doc.dart
index 775b614..d2cf4d5 100644
--- a/tool/doc.dart
+++ b/tool/doc.dart
@@ -70,7 +70,6 @@
const ruleLeadMatter = 'Rules are organized into familiar rule groups.';
final coreRules = <String?>[];
-final effectiveDartRules = <String?>[];
final flutterRules = <String?>[];
final pedanticRules = <String?>[];
final recommendedRules = <String?>[];
@@ -81,16 +80,6 @@
late Map<String, SinceInfo> sinceInfo;
-Future<String> get effectiveDartLatestVersion async {
- var url =
- 'https://raw.githubusercontent.com/tenhobi/effective_dart/master/lib/analysis_options.yaml';
- var client = http.Client();
- print('loading $url...');
- var req = await client.get(Uri.parse(url));
- var parts = req.body.split('package:effective_dart/analysis_options.');
- return parts[1].split('.yaml')[0];
-}
-
String get enumerateErrorRules =>
rules.where((r) => r.group == Group.errors).map(toDescription).join('\n\n');
@@ -145,15 +134,6 @@
}
}
- var latestEffectiveDart = await effectiveDartLatestVersion;
- var effectiveDart = await fetchConfig(
- 'https://raw.githubusercontent.com/tenhobi/effective_dart/master/lib/analysis_options.$latestEffectiveDart.yaml');
- if (effectiveDart != null) {
- for (var ruleConfig in effectiveDart.ruleConfigs) {
- effectiveDartRules.add(ruleConfig.name);
- }
- }
-
var flutter = await fetchConfig(
'https://raw.githubusercontent.com/flutter/packages/master/packages/flutter_lints/lib/flutter.yaml');
if (flutter != null) {
@@ -241,11 +221,6 @@
'<a class="style-type" href="https://github.com/dart-lang/pedantic/#enabled-lints">'
'<!--suppress HtmlUnknownTarget --><img alt="pedantic" src="style-pedantic.svg"></a>');
}
- if (effectiveDartRules.contains(rule)) {
- sb.write(
- '<a class="style-type" href="https://github.com/tenhobi/effective_dart">'
- '<!--suppress HtmlUnknownTarget --><img alt="effective dart" src="style-effective_dart.svg"></a>');
- }
return sb.toString();
}
@@ -424,10 +399,6 @@
buffer.writeln('[]'
'(https://github.com/dart-lang/pedantic/#enabled-lints)');
}
- if (effectiveDartRules.contains(rule.name)) {
- buffer.writeln('[]'
- '(https://github.com/tenhobi/effective_dart)');
- }
buffer.writeln();
}
@@ -707,10 +678,6 @@
buffer.writeln('[]'
'(https://github.com/dart-lang/pedantic/#enabled-lints)');
}
- if (effectiveDartRules.contains(name)) {
- buffer.writeln('[]'
- '(https://github.com/tenhobi/effective_dart)');
- }
buffer.writeln();
diff --git a/tool/machine.dart b/tool/machine.dart
index ffe0a69..816d575 100644
--- a/tool/machine.dart
+++ b/tool/machine.dart
@@ -47,7 +47,6 @@
if (recommendedRules.contains(rule.name)) 'recommended',
if (flutterRules.contains(rule.name)) 'flutter',
if (pedanticRules.contains(rule.name)) 'pedantic',
- if (effectiveDartRules.contains(rule.name)) 'effective_dart',
],
'details': rule.details,
}
diff --git a/tool/scorecard.dart b/tool/scorecard.dart
index 752c690..3911f3c 100644
--- a/tool/scorecard.dart
+++ b/tool/scorecard.dart
@@ -24,7 +24,6 @@
Detail.sdk,
Detail.fix,
Detail.pedantic,
- Detail.effectiveDart,
Detail.flutterUser,
Detail.flutterRepo,
Detail.status,
@@ -123,7 +122,6 @@
static const Detail fix = Detail('fix');
static const Detail pedantic = Detail('pedantic');
- static const Detail effectiveDart = Detail('effective_dart');
static const Detail flutterUser = Detail('flutter user');
static const Detail flutterRepo = Detail('flutter repo');
static const Detail status = Detail('status');
@@ -183,10 +181,6 @@
case Detail.pedantic:
sb.write('${ruleSets!.contains('pedantic') ? " $checkMark" : ""} |');
break;
- case Detail.effectiveDart:
- sb.write(
- '${ruleSets!.contains('effective_dart') ? " $checkMark" : ""} |');
- break;
case Detail.flutterUser:
sb.write('${ruleSets!.contains('flutter') ? " $checkMark" : ""} |');
break;
@@ -249,7 +243,6 @@
var flutterRuleset = await flutterRules;
var flutterRepoRuleset = await flutterRepoRules;
var pedanticRuleset = await pedanticRules;
- var effectiveDartRuleset = await effectiveDartRules;
var issues = await getLinterIssues();
var bugs = issues.where(isBug).toList();
@@ -267,9 +260,7 @@
if (pedanticRuleset.contains(lint.name)) {
ruleSets.add('pedantic');
}
- if (effectiveDartRuleset.contains(lint.name)) {
- ruleSets.add('effective_dart');
- }
+
var bugReferences = <String>[];
for (var bug in bugs) {
var title = bug.title;
