commit 929391aa89f58ecbbe2fbc24a84d26d2c6d7a6fa
author Brian Wilkerson <brianwilkerson@google.com> Tue Jan 21 09:46:38 2020 -0800
committer GitHub <noreply@github.com> Tue Jan 21 09:46:38 2020 -0800
tree 490eb726047d74074b85cefb0a95102e80030ee7
parent d6d7cd6ab4ae4da0062b4cc16bde2bfe119bf336
parent a7b8ed08c55c3d5fd1469bf769776829e0ad5c3c

Merge pull request #1973 from dart-lang/unused-deprecated-parameters

Allow unused parameters when they are deprecated

lib/src/rules/avoid_unused_constructor_parameters.dart

diff --git a/lib/src/rules/avoid_unused_constructor_parameters.dart b/lib/src/rules/avoid_unused_constructor_parameters.dart
index 0061680..ea15499 100644
--- a/lib/src/rules/avoid_unused_constructor_parameters.dart
+++ b/lib/src/rules/avoid_unused_constructor_parameters.dart
@@ -55,7 +55,9 @@
 
   _ConstructorVisitor(this.rule, this.element)
       : unusedParameters = element.parameters.parameters
-            .where((p) => p.declaredElement is! FieldFormalParameterElement)
+            .where((p) =>
+                p.declaredElement is! FieldFormalParameterElement &&
+                !p.declaredElement.hasDeprecated)
             .toSet();
 
   @override

test/rules/avoid_unused_constructor_parameters.dart

diff --git a/test/rules/avoid_unused_constructor_parameters.dart b/test/rules/avoid_unused_constructor_parameters.dart
index 9807ed1..5ebde5e 100644
--- a/test/rules/avoid_unused_constructor_parameters.dart
+++ b/test/rules/avoid_unused_constructor_parameters.dart
@@ -96,3 +96,7 @@
   external N(int n); // OK
   external factory N.named(int n); // OK
 }
+
+class O {
+  O(@Deprecated('') int x); // OK because the parameter is deprecated
+}