commit 1c75235555fd0a8d908e1b23117efdb37168a8e8
author Konstantin Scheglov <scheglov@google.com> Wed Feb 05 12:49:36 2020 -0800
committer GitHub <noreply@github.com> Wed Feb 05 12:49:35 2020 -0800
tree 927395cf4ebb3d8c2454ea8f181789269aa676e5
parent 1a2d2c0db6e96722e55a937a44f692573422fac1

[no_duplicate_case_values] Use DartObject and hasKnownValue. (#1998)

lib/src/rules/no_duplicate_case_values.dart

diff --git a/lib/src/rules/no_duplicate_case_values.dart b/lib/src/rules/no_duplicate_case_values.dart
index 3d318ea..4feae03 100644
--- a/lib/src/rules/no_duplicate_case_values.dart
+++ b/lib/src/rules/no_duplicate_case_values.dart
@@ -2,10 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:collection';
-
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/dart/constant/value.dart';
 
 import '../analyzer.dart';
 
@@ -82,23 +81,16 @@
 
   @override
   void visitSwitchStatement(SwitchStatement node) {
-    final typeProvider = context.typeProvider;
-
-    Map<DartObjectImpl, Expression> values =
-        HashMap<DartObjectImpl, Expression>(
-            equals: (DartObjectImpl key1, DartObjectImpl key2) {
-      final equals = key1.isIdentical(typeProvider, key2);
-      return equals.isBool && equals.toBoolValue();
-    });
+    var values = <DartObject, Expression>{};
 
     for (var member in node.members) {
       if (member is SwitchCase) {
         final expression = member.expression;
 
         final result = context.evaluateConstant(expression);
-        final value = result.value as DartObjectImpl;
+        final value = result.value;
 
-        if (value == null) {
+        if (value == null || !value.hasKnownValue) {
           continue;
         }