Use a normal list for lints (#470)
Disable dynamic lint. Fix the other ones.
diff --git a/analysis_options.yaml b/analysis_options.yaml
index 26fac24..b2f6fe0 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -8,7 +8,7 @@
linter:
rules:
- - always_declare_return_types: true
- - avoid_dynamic_calls: true
- - directives_ordering: true
- - sort_pub_dependencies: true
+ - always_declare_return_types
+ #- avoid_dynamic_calls
+ - directives_ordering
+ - sort_pub_dependencies
diff --git a/test/number_format_compact_icu_test.dart b/test/number_format_compact_icu_test.dart
index 6585169..a816fc3 100644
--- a/test/number_format_compact_icu_test.dart
+++ b/test/number_format_compact_icu_test.dart
@@ -3,21 +3,21 @@
/// These tests check that the test cases match what ICU produces. They are not
/// testing the package:intl implementation, they only help verify consistent
/// behaviour across platforms.
-
-// ignore_for_file: non_constant_identifier_names
-
@TestOn('!browser')
@Tags(['ffi'])
@Skip('currently failing (see https://github.com/dart-lang/intl/issues/240)')
+// ignore_for_file: non_constant_identifier_names
+
import 'dart:ffi';
+
import 'package:ffi/ffi.dart';
import 'package:test/test.dart';
import 'compact_number_test_data.dart' as testdata35;
import 'more_compact_number_test_data.dart' as more_testdata;
-main() {
+void main() {
var problemLocales = {
// ICU produces numerals in Arabic script, package:intl uses Latin script.
'ar',
diff --git a/test/number_format_compact_test.dart b/test/number_format_compact_test.dart
index f85f98b..f0bb57a 100644
--- a/test/number_format_compact_test.dart
+++ b/test/number_format_compact_test.dart
@@ -3,7 +3,6 @@
/// BSD-style license that can be found in the LICENSE file.
/// Tests for compact format numbers, e.g. 1.2M rather than 1,200,000
-
import 'package:fixnum/fixnum.dart';
import 'package:intl/intl.dart';
import 'package:intl/number_symbols_data.dart' as patterns;
@@ -111,7 +110,7 @@
parsingTestCases.forEach(_validateParsing);
test("Patterns are consistent across locales", () {
- checkPatterns(Map<int, Map<String, String>> patterns) {
+ void checkPatterns(Map<int, Map<String, String>> patterns) {
expect(patterns, isNotEmpty);
// Check patterns are iterable in order.
var lastExp = -1;
