Drop an obsolete hack for async as argument name (#319)
This was working around a bug where in an `async` method you couldn't
use `async` as a named argument in a call.
Bump min SDK to `2.4.0`, it fixes the analyzer bug.
diff --git a/.travis.yml b/.travis.yml
index 7acc0b1..f0dd98d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,7 +2,7 @@
dart:
- dev
- - 2.2.0
+ - 2.4.0
dart_task:
- test: --platform vm
diff --git a/lib/src/browser_client.dart b/lib/src/browser_client.dart
index 597c788..76c613d 100644
--- a/lib/src/browser_client.dart
+++ b/lib/src/browser_client.dart
@@ -45,8 +45,8 @@
var bytes = await request.finalize().toBytes();
var xhr = HttpRequest();
_xhrs.add(xhr);
- _openHttpRequest(xhr, request.method, request.url.toString(), asynch: true);
xhr
+ ..open(request.method, '${request.url}', async: true)
..responseType = 'blob'
..withCredentials = withCredentials;
request.headers.forEach(xhr.setRequestHeader);
@@ -93,12 +93,6 @@
}
}
- // TODO(nweiz): Remove this when sdk#24637 is fixed.
- void _openHttpRequest(HttpRequest request, String method, String url,
- {bool asynch, String user, String password}) {
- request.open(method, url, async: asynch, user: user, password: password);
- }
-
/// Closes the client.
///
/// This terminates all active requests.
diff --git a/pubspec.yaml b/pubspec.yaml
index 17703eb..270e395 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -5,7 +5,7 @@
description: A composable, multi-platform, Future-based API for HTTP requests.
environment:
- sdk: ">=2.2.0 <3.0.0"
+ sdk: ">=2.4.0 <3.0.0"
dependencies:
async: ">=1.10.0 <3.0.0"
