commit e37bb487bbac7d8000c78602c38020200b48812e
author Kevin Moore <kevmoo@google.com> Tue Nov 06 19:07:00 2018 -0800
committer Kevin Moore <kevmoo@users.noreply.github.com> Tue Nov 06 19:11:27 2018 -0800
tree 2f1edc1eca91fd1f8138fad4c8fb4833f99fb0c2
parent 8ed49bdff6d6625d984ad50986f85b0cefee0c3c

fix some more lints

.travis.yml

diff --git a/.travis.yml b/.travis.yml
index c22b630..7a04dbd 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,13 +1,14 @@
 language: dart
 
 dart:
+ - stable
  - dev
 
 dart_task:
  - test: --platform vm
    xvfb: false
- - test: --platform firefox -j 1
- - dartanalyzer: --fatal-warnings .
+ - test: --platform chrome
+ - dartanalyzer: --fatal-warnings --fatal-infos .
  - dartfmt
 
 # Only building master means that we don't run two builds for each pull request.

test/int32_test.dart

diff --git a/test/int32_test.dart b/test/int32_test.dart
index e76a0dc..52764b6 100644
--- a/test/int32_test.dart
+++ b/test/int32_test.dart
@@ -213,18 +213,18 @@
     });
 
     test("==", () {
-      expect(Int32(17) == Int32(18), false);
-      expect(Int32(17) == Int32(17), true);
-      expect(Int32(17) == Int32(16), false);
-      expect(Int32(17) == Int64(18), false);
-      expect(Int32(17) == Int64(17), true);
-      expect(Int32(17) == Int64(16), false);
-      expect(Int32.MIN_VALUE == Int32.MAX_VALUE, false);
-      expect(Int32(17) == 18, false);
-      expect(Int32(17) == 17, true);
-      expect(Int32(17) == 16, false);
-      expect(Int32(17) == Object(), false);
-      expect(Int32(17) == null, false);
+      expect(Int32(17), isNot(equals(Int32(18))));
+      expect(Int32(17), equals(Int32(17)));
+      expect(Int32(17), isNot(equals(Int32(16))));
+      expect(Int32(17), isNot(equals(Int64(18))));
+      expect(Int32(17), equals(Int64(17)));
+      expect(Int32(17), isNot(equals(Int64(16))));
+      expect(Int32.MIN_VALUE, isNot(equals(Int32.MAX_VALUE)));
+      expect(Int32(17), isNot(equals(18)));
+      expect(Int32(17) == 17, isTrue);
+      expect(Int32(17), isNot(equals(16)));
+      expect(Int32(17), isNot(equals(Object())));
+      expect(Int32(17), isNot(equals(null)));
     });
 
     test(">=", () {

test/int64_test.dart

diff --git a/test/int64_test.dart b/test/int64_test.dart
index ac6b6b0..baa2f14 100644
--- a/test/int64_test.dart
+++ b/test/int64_test.dart
@@ -373,31 +373,31 @@
     });
 
     test("==", () {
-      expect(Int64(0) == Int64(0), true);
-      expect(Int64(0) == Int64(1), false);
-      expect(Int64(0) == Int32(0), true);
-      expect(Int64(0) == Int32(1), false);
-      expect(Int64(0) == 0, true);
-      expect(Int64(0) == 1, false);
-      expect(Int64(10) == Int64(11), false);
-      expect(Int64(10) == Int64(10), true);
-      expect(Int64(10) == Int64(9), false);
-      expect(Int64(10) == Int32(11), false);
-      expect(Int64(10) == Int32(10), true);
-      expect(Int64(10) == Int32(9), false);
-      expect(Int64(10) == 11, false);
-      expect(Int64(10) == 10, true);
-      expect(Int64(10) == 9, false);
-      expect(Int64(-10) == Int64(-10), true);
+      expect(Int64(0), equals(Int64(0)));
+      expect(Int64(0), isNot(equals(Int64(1))));
+      expect(Int64(0), equals(Int32(0)));
+      expect(Int64(0), isNot(equals(Int32(1))));
+      expect(Int64(0) == 0, isTrue);
+      expect(Int64(0), isNot(equals(1)));
+      expect(Int64(10), isNot(equals(Int64(11))));
+      expect(Int64(10), equals(Int64(10)));
+      expect(Int64(10), isNot(equals(Int64(9))));
+      expect(Int64(10), isNot(equals(Int32(11))));
+      expect(Int64(10), equals(Int32(10)));
+      expect(Int64(10), isNot(equals(Int32(9))));
+      expect(Int64(10), isNot(equals(11)));
+      expect(Int64(10) == 10, isTrue);
+      expect(Int64(10), isNot(equals(9)));
+      expect(Int64(-10), equals(Int64(-10)));
       expect(Int64(-10) != Int64(-10), false);
-      expect(Int64(-10) == -10, true);
-      expect(Int64(-10) == -9, false);
-      expect(largePos == largePos, true);
-      expect(largePos == largePosPlusOne, false);
-      expect(largePosPlusOne == largePos, false);
-      expect(Int64.MIN_VALUE == Int64.MAX_VALUE, false);
-      expect(Int64(17) == Object(), false);
-      expect(Int64(17) == null, false);
+      expect(Int64(-10) == -10, isTrue);
+      expect(Int64(-10), isNot(equals(-9)));
+      expect(largePos, equals(largePos));
+      expect(largePos, isNot(equals(largePosPlusOne)));
+      expect(largePosPlusOne, isNot(equals(largePos)));
+      expect(Int64.MIN_VALUE, isNot(equals(Int64.MAX_VALUE)));
+      expect(Int64(17), isNot(equals(Object())));
+      expect(Int64(17), isNot(equals(null)));
     });
 
     test(">=", () {