Try to fix some flaky tests (#150)
The suite of common tests repeatedly opens `IOSink`s and
`StreamController`s but closed them only the first time. I don't
definitively know that this was the cause for many of the test flakes
related to local filesystems, but with this change, I haven't hit
file-not-found flakes locally after several hundred iterations of
running `chroot_test.dart`.
diff --git a/packages/file/test/common_tests.dart b/packages/file/test/common_tests.dart
index ceeef74..e52dd49 100644
--- a/packages/file/test/common_tests.dart
+++ b/packages/file/test/common_tests.dart
@@ -2215,7 +2215,7 @@
group('ioSink', () {
File f;
IOSink sink;
- bool isSinkClosed = false;
+ bool isSinkClosed;
Future<dynamic> closeSink() {
Future<dynamic> future = sink.close();
@@ -2226,6 +2226,7 @@
setUp(() {
f = fs.file(ns('/foo'));
sink = f.openWrite();
+ isSinkClosed = false;
});
tearDown(() async {
@@ -2303,8 +2304,8 @@
test('returnsAccurateDoneFuture', () async {
bool done = false;
- sink.done
- .then((dynamic _) => done = true); // ignore: unawaited_futures
+ // ignore: unawaited_futures
+ sink.done.then((dynamic _) => done = true);
expect(done, isFalse);
sink.write('foo');
expect(done, isFalse);
@@ -2314,7 +2315,7 @@
group('addStream', () {
StreamController<List<int>> controller;
- bool isControllerClosed = false;
+ bool isControllerClosed;
Future<dynamic> closeController() {
Future<dynamic> future = controller.close();
@@ -2324,6 +2325,7 @@
setUp(() {
controller = StreamController<List<int>>();
+ isControllerClosed = false;
sink.addStream(controller.stream);
});
