upgrade to lints 2.0.0 (#87)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 75feee5..121b26f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,5 @@
-# webkit_inspection_protocol.dart
+## 1.0.2-dev
+
## 1.0.1
- Use `package:lints` for analysis.
diff --git a/example/multiplex_impl.dart b/example/multiplex_impl.dart
index 0f64d23..c8eeb34 100644
--- a/example/multiplex_impl.dart
+++ b/example/multiplex_impl.dart
@@ -128,6 +128,8 @@
}
_log.info('connecting to websocket: ${request.url}');
+ // TODO: The first arg of webSocketHandler is untyped; consider refactoring
+ // (in package:web_socket_channel) to use a typedef.
return ws.webSocketHandler((WebSocketChannel webSocket) async {
var debugger = await _connections.putIfAbsent(path[2], () async {
var tab = (await chrome.getTab((tab) => tab.id == path[2]))!;
diff --git a/lib/src/runtime.dart b/lib/src/runtime.dart
index 4089fae..ada5399 100644
--- a/lib/src/runtime.dart
+++ b/lib/src/runtime.dart
@@ -289,8 +289,8 @@
});
return frames.map((CallFrame frame) {
- return '${frame.functionName}()'.padRight(width + 2) +
- ' ${frame.url} ${frame.lineNumber}:${frame.columnNumber}';
+ var name = '${frame.functionName}()'.padRight(width + 2);
+ return '$name ${frame.url} ${frame.lineNumber}:${frame.columnNumber}';
}).toList();
}
diff --git a/lib/webkit_inspection_protocol.dart b/lib/webkit_inspection_protocol.dart
index 1b1a51a..ff5a7e2 100644
--- a/lib/webkit_inspection_protocol.dart
+++ b/lib/webkit_inspection_protocol.dart
@@ -305,6 +305,7 @@
}
}
+// ignore: library_private_types_in_public_api
const _Experimental experimental = _Experimental();
class _Experimental {
diff --git a/pubspec.yaml b/pubspec.yaml
index bb5dd9f..d4850c0 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,5 +1,5 @@
name: webkit_inspection_protocol
-version: 1.0.1
+version: 1.0.2-dev
description: >
A client for the Chrome DevTools Protocol (previously called the Webkit
Inspection Protocol).
@@ -13,9 +13,10 @@
dev_dependencies:
args: ^2.0.0
- lints: ^1.0.0
+ lints: ^2.0.0
shelf_static: ^1.0.0
shelf_web_socket: ^1.0.0
shelf: ^1.0.0
test: ^1.16.0
+ web_socket_channel: ^2.0.0 # used in example/
webdriver: ^3.0.0
diff --git a/test/test_setup.dart b/test/test_setup.dart
index 03cc9f8..857e445 100644
--- a/test/test_setup.dart
+++ b/test/test_setup.dart
@@ -37,8 +37,8 @@
await Future.delayed(const Duration(milliseconds: 25));
try {
- var _exeExt = Platform.isWindows ? '.exe' : '';
- _chromeDriver = await Process.start('chromedriver$_exeExt',
+ var exeExt = Platform.isWindows ? '.exe' : '';
+ _chromeDriver = await Process.start('chromedriver$exeExt',
['--port=$chromeDriverPort', '--url-base=wd/hub']);
// On windows this takes a while to boot up, wait for the first line
// of stdout as a signal that it is ready.
