remove noop primitive operations (#82297)
diff --git a/dev/devicelab/lib/framework/apk_utils.dart b/dev/devicelab/lib/framework/apk_utils.dart
index f368f1d..c1d148d 100644
--- a/dev/devicelab/lib/framework/apk_utils.dart
+++ b/dev/devicelab/lib/framework/apk_utils.dart
@@ -453,7 +453,6 @@
' Arguments: ${args.join(' ')}\n'
' Working directory: $workingDirectory\n'
' JAVA_HOME: $javaHome\n'
- ''
);
return Process.run(
gradle,
diff --git a/dev/manual_tests/lib/text.dart b/dev/manual_tests/lib/text.dart
index f7550d5..f88f851 100644
--- a/dev/manual_tests/lib/text.dart
+++ b/dev/manual_tests/lib/text.dart
@@ -99,7 +99,7 @@
min: 0.0,
max: 1024.0,
value: seed.toDouble(),
- label: '${seed.round()}',
+ label: '$seed',
divisions: 1025,
onChanged: (double value) {
setState(() {
diff --git a/packages/flutter/lib/src/material/dialog.dart b/packages/flutter/lib/src/material/dialog.dart
index 99d22ca..556e0d4 100644
--- a/packages/flutter/lib/src/material/dialog.dart
+++ b/packages/flutter/lib/src/material/dialog.dart
@@ -1152,7 +1152,7 @@
}
double _paddingScaleFactor(double textScaleFactor) {
- final double clampedTextScaleFactor = textScaleFactor.clamp(1.0, 2.0).toDouble();
+ final double clampedTextScaleFactor = textScaleFactor.clamp(1.0, 2.0);
// The final padding scale factor is clamped between 1/3 and 1. For example,
// a non-scaled padding of 24 will produce a padding between 24 and 8.
return lerpDouble(1.0, 1.0 / 3.0, clampedTextScaleFactor - 1.0)!;
diff --git a/packages/flutter/lib/src/material/scaffold.dart b/packages/flutter/lib/src/material/scaffold.dart
index 953626f..f855603 100644
--- a/packages/flutter/lib/src/material/scaffold.dart
+++ b/packages/flutter/lib/src/material/scaffold.dart
@@ -924,7 +924,7 @@
if (extendBody) {
bodyMaxHeight += bottomWidgetsHeight;
- bodyMaxHeight = bodyMaxHeight.clamp(0.0, looseConstraints.maxHeight - contentTop).toDouble();
+ bodyMaxHeight = bodyMaxHeight.clamp(0.0, looseConstraints.maxHeight - contentTop);
assert(bodyMaxHeight <= math.max(0.0, looseConstraints.maxHeight - contentTop));
}
diff --git a/packages/flutter/lib/src/material/tabs.dart b/packages/flutter/lib/src/material/tabs.dart
index 87c0572..1279f98 100644
--- a/packages/flutter/lib/src/material/tabs.dart
+++ b/packages/flutter/lib/src/material/tabs.dart
@@ -423,8 +423,8 @@
final double index = controller.index.toDouble();
final double value = controller.animation!.value;
final bool ltr = index > value;
- final int from = (ltr ? value.floor() : value.ceil()).clamp(0, maxTabIndex).toInt();
- final int to = (ltr ? from + 1 : from - 1).clamp(0, maxTabIndex).toInt();
+ final int from = (ltr ? value.floor() : value.ceil()).clamp(0, maxTabIndex);
+ final int to = (ltr ? from + 1 : from - 1).clamp(0, maxTabIndex);
final Rect fromRect = indicatorRect(size, from);
final Rect toRect = indicatorRect(size, to);
_currentRect = Rect.lerp(fromRect, toRect, (value - from).abs());
diff --git a/packages/flutter/lib/src/material/theme_data.dart b/packages/flutter/lib/src/material/theme_data.dart
index ae5d5f8..17814e3 100644
--- a/packages/flutter/lib/src/material/theme_data.dart
+++ b/packages/flutter/lib/src/material/theme_data.dart
@@ -2273,8 +2273,8 @@
BoxConstraints effectiveConstraints(BoxConstraints constraints){
assert(constraints != null && constraints.debugAssertIsValid());
return constraints.copyWith(
- minWidth: (constraints.minWidth + baseSizeAdjustment.dx).clamp(0.0, double.infinity).toDouble(),
- minHeight: (constraints.minHeight + baseSizeAdjustment.dy).clamp(0.0, double.infinity).toDouble(),
+ minWidth: (constraints.minWidth + baseSizeAdjustment.dx).clamp(0.0, double.infinity),
+ minHeight: (constraints.minHeight + baseSizeAdjustment.dy).clamp(0.0, double.infinity),
);
}
diff --git a/packages/flutter/lib/src/widgets/interactive_viewer.dart b/packages/flutter/lib/src/widgets/interactive_viewer.dart
index 529958a..5250092 100644
--- a/packages/flutter/lib/src/widgets/interactive_viewer.dart
+++ b/packages/flutter/lib/src/widgets/interactive_viewer.dart
@@ -691,7 +691,7 @@
// the point.
final Vector3 l1P = point - l1;
final Vector3 l1L2 = l2 - l1;
- final double fraction = (l1P.dot(l1L2) / lengthSquared).clamp(0.0, 1.0).toDouble();
+ final double fraction = (l1P.dot(l1L2) / lengthSquared).clamp(0.0, 1.0);
return l1 + l1L2 * fraction;
}
diff --git a/packages/flutter/test/widgets/inherited_dependencies_test.dart b/packages/flutter/test/widgets/inherited_dependencies_test.dart
index 0a81224..2ed743e 100644
--- a/packages/flutter/test/widgets/inherited_dependencies_test.dart
+++ b/packages/flutter/test/widgets/inherited_dependencies_test.dart
@@ -23,8 +23,7 @@
equalsIgnoringHashCodes(
'Directionality-[GlobalKey#00000](textDirection: ltr)\n'
'└Builder(dependencies: [Directionality-[GlobalKey#00000]])\n'
- ' └SizedBox(renderObject: RenderConstrainedBox#00000)\n'
- '',
+ ' └SizedBox(renderObject: RenderConstrainedBox#00000)\n',
),
);
@@ -41,8 +40,7 @@
equalsIgnoringHashCodes(
'Directionality-[GlobalKey#00000](textDirection: rtl)\n'
'└Builder(dependencies: [Directionality-[GlobalKey#00000]])\n'
- ' └SizedBox(renderObject: RenderConstrainedBox#00000)\n'
- '',
+ ' └SizedBox(renderObject: RenderConstrainedBox#00000)\n',
),
);
});
diff --git a/packages/flutter/test/widgets/navigator_test.dart b/packages/flutter/test/widgets/navigator_test.dart
index 5175db2..0ce390c 100644
--- a/packages/flutter/test/widgets/navigator_test.dart
+++ b/packages/flutter/test/widgets/navigator_test.dart
@@ -2537,8 +2537,7 @@
' - NavigatorState#00000(tickers: tracking 1 ticker)\n'
' Please create a HeroControllerScope for each Navigator or use a\n'
' HeroControllerScope.none to prevent subtree from receiving a\n'
- ' HeroController.\n'
- '',
+ ' HeroController.\n',
),
);
});
@@ -2640,8 +2639,7 @@
equalsIgnoringHashCodes(
'FlutterError\n'
' The Navigator.onPopPage must be provided to use the\n'
- ' Navigator.pages API\n'
- '',
+ ' Navigator.pages API\n',
),
);
});
@@ -2676,8 +2674,7 @@
'FlutterError\n'
' A page-based route should not be added using the imperative api.\n'
' Provide a new list with the corresponding Page to Navigator.pages\n'
- ' instead.\n'
- '',
+ ' instead.\n',
),
);
}
diff --git a/packages/flutter_test/lib/src/controller.dart b/packages/flutter_test/lib/src/controller.dart
index 6ced952..4482b1b 100644
--- a/packages/flutter_test/lib/src/controller.dart
+++ b/packages/flutter_test/lib/src/controller.dart
@@ -957,8 +957,7 @@
'The hit test result at that offset is: $result\n'
'${StackTrace.current}'
'To silence this warning, pass "warnIfMissed: false" to "$callee()".\n'
- 'To make this warning fatal, set WidgetController.hitTestWarningShouldBeFatal to true.\n'
- ''
+ 'To make this warning fatal, set WidgetController.hitTestWarningShouldBeFatal to true.\n',
);
}
}
diff --git a/packages/flutter_tools/lib/src/cache.dart b/packages/flutter_tools/lib/src/cache.dart
index b3ba3ee..0262df6 100644
--- a/packages/flutter_tools/lib/src/cache.dart
+++ b/packages/flutter_tools/lib/src/cache.dart
@@ -1021,7 +1021,7 @@
final Digest digest = await digests.stream.last;
final String rawDigest = base64.encode(digest.bytes);
if (rawDigest != md5Hash) {
- throw Exception(''
+ throw Exception(
'Expected $url to have md5 checksum $md5Hash, but was $rawDigest. This '
'may indicate a problem with your connection to the Flutter backend servers. '
'Please re-try the download after confirming that your network connection is '
diff --git a/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
index 089da9e..68329da 100644
--- a/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
+++ b/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
@@ -516,7 +516,6 @@
'\n'
'! Doctor found issues in 4\n'
' categories.\n'
- ''
));
}, overrides: <Type, Generator>{
Platform: _kNoColorOutputPlatform,
@@ -563,7 +562,6 @@
'\n'
'! Doctor found issues in 4\n'
' categories.\n'
- ''
));
}, overrides: <Type, Generator>{
Platform: _kNoColorOutputPlatform,
diff --git a/packages/flutter_tools/test/general.shard/build_system/targets/dart_plugin_registrant_test.dart b/packages/flutter_tools/test/general.shard/build_system/targets/dart_plugin_registrant_test.dart
index cc84830..b4aec94 100644
--- a/packages/flutter_tools/test/general.shard/build_system/targets/dart_plugin_registrant_test.dart
+++ b/packages/flutter_tools/test/general.shard/build_system/targets/dart_plugin_registrant_test.dart
@@ -280,7 +280,6 @@
' (entrypoint.main as _NullaryFunction)();\n'
' }\n'
'}\n'
- ''
),
);
});
@@ -418,7 +417,6 @@
' (entrypoint.main as _NullaryFunction)();\n'
' }\n'
'}\n'
- ''
),
);
});
diff --git a/packages/flutter_tools/test/general.shard/dart_plugin_test.dart b/packages/flutter_tools/test/general.shard/dart_plugin_test.dart
index 98a62ab..0eef061 100644
--- a/packages/flutter_tools/test/general.shard/dart_plugin_test.dart
+++ b/packages/flutter_tools/test/general.shard/dart_plugin_test.dart
@@ -731,8 +731,7 @@
' } else {\n'
' (entrypoint.main as _NullaryFunction)();\n'
' }\n'
- '}\n'
- '',
+ '}\n',
);
}, overrides: <Type, Generator>{
FileSystem: () => fs,
diff --git a/packages/flutter_tools/test/general.shard/plugins_test.dart b/packages/flutter_tools/test/general.shard/plugins_test.dart
index fcff426..a248ff2 100644
--- a/packages/flutter_tools/test/general.shard/plugins_test.dart
+++ b/packages/flutter_tools/test/general.shard/plugins_test.dart
@@ -437,7 +437,6 @@
'plugin-a=${pluginA.path}/\n'
'plugin-b=${pluginB.path}/\n'
'plugin-c=${pluginC.path}/\n'
- ''
);
final String pluginsString = flutterProject.flutterPluginsDependenciesFile.readAsStringSync();
