commit e89747abcb464123ff466755445acf280fba8781
author Taha Tesser <tessertaha@gmail.com> Thu Jul 29 00:49:05 2021 +0300
committer GitHub <noreply@github.com> Wed Jul 28 14:49:05 2021 -0700
tree 93f1f8450a1865cb411ce32f063d1db1802a8617
parent 984056c7ed7244ab7fa23cdf5ce921c55d53bf75

fix numpadEnter default shortcut (#87019)

packages/flutter/lib/src/widgets/app.dart

diff --git a/packages/flutter/lib/src/widgets/app.dart b/packages/flutter/lib/src/widgets/app.dart
index 56c5ca3..1ff1c51 100644
--- a/packages/flutter/lib/src/widgets/app.dart
+++ b/packages/flutter/lib/src/widgets/app.dart
@@ -1152,6 +1152,7 @@
   static const Map<ShortcutActivator, Intent> _defaultShortcuts = <ShortcutActivator, Intent>{
     // Activation
     SingleActivator(LogicalKeyboardKey.enter): ActivateIntent(),
+    SingleActivator(LogicalKeyboardKey.numpadEnter): ActivateIntent(),
     SingleActivator(LogicalKeyboardKey.space): ActivateIntent(),
     SingleActivator(LogicalKeyboardKey.gameButtonA): ActivateIntent(),
 
@@ -1186,6 +1187,7 @@
     ),
     // On the web, enter activates buttons, but not other controls.
     SingleActivator(LogicalKeyboardKey.enter): ButtonActivateIntent(),
+    SingleActivator(LogicalKeyboardKey.numpadEnter): ButtonActivateIntent(),
 
     // Dismissal
     SingleActivator(LogicalKeyboardKey.escape): DismissIntent(),
@@ -1207,6 +1209,7 @@
   static const Map<ShortcutActivator, Intent> _defaultAppleOsShortcuts = <ShortcutActivator, Intent>{
     // Activation
     SingleActivator(LogicalKeyboardKey.enter): ActivateIntent(),
+    SingleActivator(LogicalKeyboardKey.numpadEnter): ActivateIntent(),
     SingleActivator(LogicalKeyboardKey.space): ActivateIntent(),
 
     // Dismissal

packages/flutter/test/widgets/app_test.dart

diff --git a/packages/flutter/test/widgets/app_test.dart b/packages/flutter/test/widgets/app_test.dart
index 944d9c7..5fa16ab 100644
--- a/packages/flutter/test/widgets/app_test.dart
+++ b/packages/flutter/test/widgets/app_test.dart
@@ -140,6 +140,11 @@
     expect(checked, isTrue);
 
     checked = false;
+    await tester.sendKeyEvent(LogicalKeyboardKey.numpadEnter);
+    await tester.pumpAndSettle();
+    expect(checked, isTrue);
+
+    checked = false;
     await tester.sendKeyEvent(LogicalKeyboardKey.gameButtonA);
     await tester.pumpAndSettle();
     expect(checked, isTrue);