commit b63bcaa3c925ec1406b96570efda96f83e710b9f
author Xavier H <xavier.hainaux@gmail.com> Wed Jun 23 18:06:03 2021 +0200
committer GitHub <noreply@github.com> Wed Jun 23 09:06:03 2021 -0700
tree 8cf9d2532d4a3f80f5c843ced305e004d53f422f
parent 69f2f8a18bb8bee86f47f1fb62d4897e9156e30a

ListTile.divideTiles only run Iterable once (#78879)

packages/flutter/lib/src/material/list_tile.dart

diff --git a/packages/flutter/lib/src/material/list_tile.dart b/packages/flutter/lib/src/material/list_tile.dart
index fbdacd8..730a3f4 100644
--- a/packages/flutter/lib/src/material/list_tile.dart
+++ b/packages/flutter/lib/src/material/list_tile.dart
@@ -980,11 +980,11 @@
     assert(tiles != null);
     assert(color != null || context != null);
 
-    if (tiles.isEmpty)
-      return;
-
     final Iterator<Widget> iterator = tiles.iterator;
-    final bool isNotEmpty = iterator.moveNext();
+    final bool hasNext = iterator.moveNext();
+
+    if (!hasNext)
+      return;
 
     final Decoration decoration = BoxDecoration(
       border: Border(
@@ -1001,7 +1001,7 @@
       );
       tile = iterator.current;
     }
-    if (isNotEmpty)
+    if (hasNext)
       yield tile;
   }
 

packages/flutter/test/material/list_tile_test.dart

diff --git a/packages/flutter/test/material/list_tile_test.dart b/packages/flutter/test/material/list_tile_test.dart
index 220fabb..8b4947e 100644
--- a/packages/flutter/test/material/list_tile_test.dart
+++ b/packages/flutter/test/material/list_tile_test.dart
@@ -257,6 +257,20 @@
     expect(output, isEmpty);
   });
 
+  testWidgets('ListTile.divideTiles only runs the generator once', (WidgetTester tester) async {
+    // Regression test for https://github.com/flutter/flutter/pull/78879
+    int callCount = 0;
+    Iterable<Widget> generator() sync* {
+      callCount += 1;
+      yield const Text('');
+      yield const Text('');
+    }
+
+    final List<Widget> output = ListTile.divideTiles(tiles: generator(), color: Colors.grey).toList();
+    expect(output, hasLength(2));
+    expect(callCount, 1);
+  });
+
   testWidgets('ListTileTheme', (WidgetTester tester) async {
     final Key titleKey = UniqueKey();
     final Key subtitleKey = UniqueKey();