commit ee2ac2a5afc33b25f5d163134237d7d7fca39f0b
author Basit Ayantunde <rlamarrr@gmail.com> Thu Jan 14 14:33:29 2021 -0800
committer GitHub <noreply@github.com> Thu Jan 14 14:33:29 2021 -0800
tree fdbae7efb343ec32cf017d706361e902db328fe9
parent a43b2bd9078c8b8f022a390ddd629266f95ea313

removed variable-sized array (#23102)

This is undefined behavior. I've replaced it with std::vector instead

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

vulkan/vulkan_device.cc

diff --git a/vulkan/vulkan_device.cc b/vulkan/vulkan_device.cc
index b4e0071..e2d45bb 100644
--- a/vulkan/vulkan_device.cc
+++ b/vulkan/vulkan_device.cc
@@ -288,9 +288,11 @@
     return -1;
   }
 
-  VkSurfaceFormatKHR formats[format_count];
+  std::vector<VkSurfaceFormatKHR> formats;
+  formats.resize(format_count);
+
   if (VK_CALL_LOG_ERROR(vk.GetPhysicalDeviceSurfaceFormatsKHR(
-          physical_device_, surface.Handle(), &format_count, formats)) !=
+          physical_device_, surface.Handle(), &format_count, formats.data())) !=
       VK_SUCCESS) {
     return -1;
   }