commit 1b3b4ec88f34bbce97cff181ea45ef3991f5065b
author Nurhan Turgut <nurhan@google.com> Fri May 08 13:30:13 2020 -0700
committer GitHub <noreply@github.com> Fri May 08 13:30:13 2020 -0700
tree 4768bc8c5dd0998d19331f157d7a0d471a24cd5f
parent 576f0e1f9d64462b238559142bdbaac96dc8ea08

skip font loading tests for safari (#18232)

lib/web_ui/test/text/font_loading_test.dart

diff --git a/lib/web_ui/test/text/font_loading_test.dart b/lib/web_ui/test/text/font_loading_test.dart
index 3ec78a5..5b34d9d 100644
--- a/lib/web_ui/test/text/font_loading_test.dart
+++ b/lib/web_ui/test/text/font_loading_test.dart
@@ -26,8 +26,10 @@
           ui.loadFontFromList(Uint8List(0), fontFamily: 'test-font'),
           throwsA(TypeMatcher<Exception>()));
     },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/56702
         // TODO(nurhan): https://github.com/flutter/flutter/issues/50770
-        skip: browserEngine == BrowserEngine.edge);
+        skip: (browserEngine == BrowserEngine.edge ||
+            browserEngine == BrowserEngine.webkit));
 
     test('loads Blehm font from buffer', () async {
       expect(_containsFontFamily('Blehm'), false);
@@ -40,8 +42,10 @@
 
       expect(_containsFontFamily('Blehm'), true);
     },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/56702
         // TODO(nurhan): https://github.com/flutter/flutter/issues/50770
-        skip: browserEngine == BrowserEngine.edge);
+        skip: (browserEngine == BrowserEngine.edge ||
+            browserEngine == BrowserEngine.webkit));
 
     test('loading font should clear measurement caches', () async {
       final ui.ParagraphStyle style = ui.ParagraphStyle();
@@ -66,8 +70,10 @@
       expect(_containsFontFamily('Blehm'), true);
       expect(TextMeasurementService.rulerManager.rulers.length, 0);
     },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/56702
         // TODO(nurhan): https://github.com/flutter/flutter/issues/50770
-        skip: browserEngine == BrowserEngine.edge);
+        skip: (browserEngine == BrowserEngine.edge ||
+            browserEngine == BrowserEngine.webkit));
 
     test('loading font should send font change message', () async {
       final ui.PlatformMessageCallback oldHandler = ui.window.onPlatformMessage;
@@ -93,8 +99,10 @@
       expect(actualName, 'flutter/system');
       expect(message, '{"type":"fontsChange"}');
     },
+        // TODO(nurhan): https://github.com/flutter/flutter/issues/56702
         // TODO(nurhan): https://github.com/flutter/flutter/issues/50770
-        skip: browserEngine == BrowserEngine.edge);
+        skip: (browserEngine == BrowserEngine.edge ||
+            browserEngine == BrowserEngine.webkit));
   });
 }