Upgrade DCM to v1.30.0 (#9310)
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 980315d..0ac5255 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml
@@ -74,7 +74,7 @@ wget -qO- https://dcm.dev/pgp-key.public | sudo gpg --dearmor -o /usr/share/keyrings/dcm.gpg echo 'deb [signed-by=/usr/share/keyrings/dcm.gpg arch=amd64] https://dcm.dev/debian stable main' | sudo tee /etc/apt/sources.list.d/dart_stable.list sudo apt-get update - sudo apt-get install dcm=1.29.0-1 # To avoid errors add `-1` (build number) to the version + sudo apt-get install dcm=1.30.0-1 # To avoid errors add `-1` (build number) to the version sudo chmod +x /usr/bin/dcm echo "$(dcm --version)" - name: Setup Dart SDK
diff --git a/packages/devtools_app/lib/src/screens/app_size/app_size_controller.dart b/packages/devtools_app/lib/src/screens/app_size/app_size_controller.dart index cabe382..574a1e9 100644 --- a/packages/devtools_app/lib/src/screens/app_size/app_size_controller.dart +++ b/packages/devtools_app/lib/src/screens/app_size/app_size_controller.dart
@@ -360,9 +360,9 @@ deferredLoadingSupportEnabled && _hasDeferredInfo(processedJson); if (isDeferredApp.value) { - _deferredOnly = _extractDeferredUnits(Map.from(processedJson)); - _mainOnly = _extractMainUnit(Map.from(processedJson)); - _entireApp = _includeEntireApp(Map.from(processedJson)); + _deferredOnly = _extractDeferredUnits(Map.of(processedJson)); + _mainOnly = _extractMainUnit(Map.of(processedJson)); + _entireApp = _includeEntireApp(Map.of(processedJson)); _loadApp(_dataForAppUnit!); } else { // Set root name for non-deferred apps. @@ -464,17 +464,17 @@ } final oldMainOnlyFileJson = _extractMainUnit( - Map.from(oldEntireAppFileJson), + Map.of(oldEntireAppFileJson), ); final newMainOnlyFileJson = _extractMainUnit( - Map.from(newEntireAppFileJson), + Map.of(newEntireAppFileJson), ); final oldDeferredOnlyFileJson = _extractDeferredUnits( - Map.from(oldEntireAppFileJson), + Map.of(oldEntireAppFileJson), ); final newDeferredOnlyFileJson = _extractDeferredUnits( - Map.from(newEntireAppFileJson), + Map.of(newEntireAppFileJson), ); diffMap = _generateDiffMapFromAnalyzeSizeFiles(
diff --git a/packages/devtools_app/lib/src/screens/profiler/cpu_profile_model.dart b/packages/devtools_app/lib/src/screens/profiler/cpu_profile_model.dart index ee59f07..4fdeda3 100644 --- a/packages/devtools_app/lib/src/screens/profiler/cpu_profile_model.dart +++ b/packages/devtools_app/lib/src/screens/profiler/cpu_profile_model.dart
@@ -468,7 +468,7 @@ } for (final sample in originalData.cpuSamples) { - final sampleJson = Map<String, Object?>.from(sample.json); + final sampleJson = Map<String, Object?>.of(sample.json); final leafStackFrame = originalData.stackFrames[sample.leafId]!; includeSampleOrWalkUp(sample, sampleJson, leafStackFrame); }
diff --git a/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/object_store.dart b/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/object_store.dart index ac32b63..736b94f 100644 --- a/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/object_store.dart +++ b/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/object_store.dart
@@ -46,7 +46,7 @@ Widget build( BuildContext context, // ignore: avoid-dynamic, requires refactor. - data, { + dynamic data, { bool isRowSelected = false, bool isRowHovered = false, VoidCallback? onPressed,
diff --git a/packages/devtools_app/lib/src/shared/managers/error_badge_manager.dart b/packages/devtools_app/lib/src/shared/managers/error_badge_manager.dart index e0ef5de..d3d3f7d 100644 --- a/packages/devtools_app/lib/src/shared/managers/error_badge_manager.dart +++ b/packages/devtools_app/lib/src/shared/managers/error_badge_manager.dart
@@ -127,7 +127,7 @@ // Build a new map with the new error. Adding to the existing map // won't cause the ValueNotifier to fire (and it's not permitted to call // notifyListeners() directly). - final newValue = LinkedHashMap<String, DevToolsError>.from(errors.value); + final newValue = LinkedHashMap<String, DevToolsError>.of(errors.value); newValue[error.id] = error; errors.value = newValue; }
diff --git a/packages/devtools_app/lib/src/shared/offline/offline_data.dart b/packages/devtools_app/lib/src/shared/offline/offline_data.dart index a279b37..a7c6f48 100644 --- a/packages/devtools_app/lib/src/shared/offline/offline_data.dart +++ b/packages/devtools_app/lib/src/shared/offline/offline_data.dart
@@ -170,8 +170,8 @@ if (offlineDataController.shouldLoadOfflineData(screenId)) { // TODO(kenz): investigate this line of code. Do we need to be creating a // second copy of the Map from offlineDataController.offlineDataJson or - // can we use it directly to save this `Map.from` call? - final json = Map<String, Object?>.from( + // can we use it directly to save this `Map.of` call? + final json = Map<String, Object?>.of( (offlineDataController.offlineDataJson[screenId] as Map) .cast<String, Object?>(), );