Remove unused code from `standalone_ui/` (#9917)
diff --git a/analysis_options.yaml b/analysis_options.yaml
index 070a4f5..b6c61e1 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -168,7 +168,6 @@
- lib/src/screens/inspector/**_controller.dart
- lib/src/service/**
- lib/src/shared/**
- - lib/src/standalone_ui/**
- test/**
rules:
# - arguments-ordering Too strict
diff --git a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
index c8bf0e1..977798d 100644
--- a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
+++ b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
@@ -47,8 +47,6 @@
_editableWidgetData;
final _editableWidgetData = ValueNotifier<EditableWidgetData?>(null);
- List<EditableProperty> get allProperties =>
- _editableWidgetData.value?.properties ?? [];
String? get widgetName => _editableWidgetData.value?.name;
String? get widgetDocumentation => _editableWidgetData.value?.documentation;
String? get fileUri => _editableWidgetData.value?.fileUri;
diff --git a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_panel.dart b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_panel.dart
index 6558652..bde7dd0 100644
--- a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_panel.dart
+++ b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_panel.dart
@@ -62,11 +62,9 @@
future: _editor,
builder: (context, snapshot) =>
switch ((snapshot.connectionState, snapshot.data)) {
- (ConnectionState.done, final editor?) =>
- _PropertyEditorConnectedPanel(
- editor,
- controller: _propertyEditorController!,
- ),
+ (ConnectionState.done, final _) => _PropertyEditorConnectedPanel(
+ controller: _propertyEditorController!,
+ ),
_ => const CenteredCircularProgressIndicator(),
},
),
@@ -76,9 +74,8 @@
/// The property editor panel shown once we know an editor is available.
class _PropertyEditorConnectedPanel extends StatefulWidget {
- const _PropertyEditorConnectedPanel(this.editor, {required this.controller});
+ const _PropertyEditorConnectedPanel({required this.controller});
- final EditorClient editor;
final PropertyEditorController controller;
@override
diff --git a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/utils/_utils_desktop.dart b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/utils/_utils_desktop.dart
deleted file mode 100644
index 0f51762..0000000
--- a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/utils/_utils_desktop.dart
+++ /dev/null
@@ -1,7 +0,0 @@
-// Copyright 2025 The Flutter Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
-
-void reloadIframe() {
- // No-op for desktop platforms.
-}
diff --git a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/utils/_utils_web.dart b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/utils/_utils_web.dart
deleted file mode 100644
index cf386af..0000000
--- a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/utils/_utils_web.dart
+++ /dev/null
@@ -1,9 +0,0 @@
-// Copyright 2025 The Flutter Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
-
-import 'package:web/web.dart';
-
-void reloadIframe() {
- window.location.reload();
-}
diff --git a/packages/devtools_app/lib/src/standalone_ui/vs_code/debug_sessions.dart b/packages/devtools_app/lib/src/standalone_ui/vs_code/debug_sessions.dart
index 033255a..79ec991 100644
--- a/packages/devtools_app/lib/src/standalone_ui/vs_code/debug_sessions.dart
+++ b/packages/devtools_app/lib/src/standalone_ui/vs_code/debug_sessions.dart
@@ -17,7 +17,6 @@
const DebugSessions({
required this.editor,
required this.sessions,
- required this.devices,
super.key,
});
@@ -26,9 +25,6 @@
/// A map of debug session IDs to their debug sessions.
final Map<String, EditorDebugSession> sessions;
- /// A map of device IDs to their devices.
- final Map<String, EditorDevice> devices;
-
@override
Widget build(BuildContext context) {
return Column(
diff --git a/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/devtools_view.dart b/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/devtools_view.dart
index 87a8fd5..9d01c67 100644
--- a/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/devtools_view.dart
+++ b/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/devtools_view.dart
@@ -118,7 +118,6 @@
(s) => createDevToolsScreenRow(
dataLeft: _buttonDataFromScreen(s),
dataRight: null,
- editor: editor,
singleColumn: singleColumn,
hasDebugSessions: debugSessions.isNotEmpty,
onPressed: (data) => openDevToolsScreen(
@@ -140,7 +139,6 @@
createDevToolsScreenRow(
dataLeft: _buttonDataFromScreen(first),
dataRight: second != null ? _buttonDataFromScreen(second) : null,
- editor: editor,
singleColumn: singleColumn,
hasDebugSessions: debugSessions.isNotEmpty,
onPressed: (data) => openDevToolsScreen(
diff --git a/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/extensions_view.dart b/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/extensions_view.dart
index 5de8f6b..b6b4b73 100644
--- a/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/extensions_view.dart
+++ b/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/extensions_view.dart
@@ -107,7 +107,6 @@
// because we do not have control over how long the names
// will be and we want to avoid ugly text wrapping.
singleColumn: true,
- editor: widget.editor,
hasDebugSessions: widget.debugSessions.isNotEmpty,
onPressed: (data) {
ga.select(
diff --git a/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/shared.dart b/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/shared.dart
index 10ec203..e64162a 100644
--- a/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/shared.dart
+++ b/packages/devtools_app/lib/src/standalone_ui/vs_code/devtools/shared.dart
@@ -25,7 +25,6 @@
required DevToolsButtonData? dataRight,
required bool singleColumn,
required bool hasDebugSessions,
- required EditorClient editor,
required void Function(DevToolsButtonData data) onPressed,
}) {
assert(
@@ -35,7 +34,6 @@
final cellRight = dataRight != null
? _DevToolsScreenButton(
data: dataRight,
- editor: editor,
hasDebugSessions: hasDebugSessions,
onPressed: onPressed,
)
@@ -44,7 +42,6 @@
children: [
_DevToolsScreenButton(
data: dataLeft,
- editor: editor,
hasDebugSessions: hasDebugSessions,
onPressed: onPressed,
),
@@ -56,13 +53,11 @@
class _DevToolsScreenButton extends StatelessWidget {
const _DevToolsScreenButton({
required this.data,
- required this.editor,
required this.hasDebugSessions,
required this.onPressed,
});
final DevToolsButtonData data;
- final EditorClient editor;
final bool hasDebugSessions;
final void Function(DevToolsButtonData data) onPressed;
diff --git a/packages/devtools_app/lib/src/standalone_ui/vs_code/flutter_panel.dart b/packages/devtools_app/lib/src/standalone_ui/vs_code/flutter_panel.dart
index a540ca7..c6704ed 100644
--- a/packages/devtools_app/lib/src/standalone_ui/vs_code/flutter_panel.dart
+++ b/packages/devtools_app/lib/src/standalone_ui/vs_code/flutter_panel.dart
@@ -174,11 +174,7 @@
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
- DebugSessions(
- editor: widget.editor,
- sessions: debugSessions,
- devices: devices,
- ),
+ DebugSessions(editor: widget.editor, sessions: debugSessions),
const SizedBox(height: defaultSpacing),
if (widget.editor.supportsSelectDevice) ...[
Devices(
diff --git a/packages/devtools_app/test/standalone_ui/vs_code/debug_sessions_test.dart b/packages/devtools_app/test/standalone_ui/vs_code/debug_sessions_test.dart
index 1bb122e..a6aa785 100644
--- a/packages/devtools_app/test/standalone_ui/vs_code/debug_sessions_test.dart
+++ b/packages/devtools_app/test/standalone_ui/vs_code/debug_sessions_test.dart
@@ -4,7 +4,6 @@
import 'package:devtools_app/devtools_app.dart';
import 'package:devtools_app/src/shared/constants.dart';
-import 'package:devtools_app/src/shared/editor/api_classes.dart';
import 'package:devtools_app/src/standalone_ui/vs_code/debug_sessions.dart';
import 'package:devtools_app_shared/ui.dart';
import 'package:devtools_app_shared/utils.dart';
@@ -14,22 +13,17 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:mockito/mockito.dart';
-import '../../test_infra/scenes/standalone_ui/editor_service/simulated_editor.dart';
import '../../test_infra/utils/sidebar_utils.dart';
void main() {
const windowSize = Size(2000.0, 2000.0);
late MockEditorClient mockEditorClient;
- late final Map<String, EditorDevice> deviceMap;
setUpAll(() {
// Set test mode so that the debug list of extensions will be used.
setTestMode();
setGlobal(ServiceConnectionManager, FakeServiceConnectionManager());
-
- final devices = stubbedDevices.map((d) => MapEntry(d.id, d));
- deviceMap = {for (final d in devices) d.key: d.value};
});
setUp(() {
@@ -52,7 +46,6 @@
sessions: Map.fromEntries(
_debugSessions.map((s) => MapEntry(s.id, s)),
),
- devices: deviceMap,
),
),
);
