Fix analysis warnings on master (#6676)
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index c5ec50e..2869a96 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml
@@ -40,6 +40,30 @@ BOT: main run: ./tool/bots.sh + # TODO(https://github.com/dart-lang/sdk/issues/53992): we can remove this + # once this issue is resolved and the `devtools_tool analyze` check is moved + # back into the "main" handler in bots.sh. + analyze: + name: analyze + needs: flutter-prep + runs-on: macos-latest + strategy: + fail-fast: false + steps: + - name: git clone + uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac + - name: Load Cached Flutter SDK + uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 + with: + path: | + ./flutter-sdk + key: flutter-sdk-${{ runner.os }}-${{ needs.flutter-prep.outputs.latest_flutter_candidate }} + + - name: tool/bots.sh + env: + BOT: analyze + run: ./tool/bots.sh + dcm: name: Dart Code Metrics needs: flutter-prep
diff --git a/tool/RELEASE_INSTRUCTIONS.md b/tool/RELEASE_INSTRUCTIONS.md index 821b1ce..8d31577 100644 --- a/tool/RELEASE_INSTRUCTIONS.md +++ b/tool/RELEASE_INSTRUCTIONS.md
@@ -20,7 +20,7 @@ 2. Your Flutter version is equal to latest candidate release branch: - Run `devtools_tool update-flutter-sdk --local` -3. You have goma [configured](http://go/ma-mac-setup). +3. You have goma [configured](http://go/ma-mac-setup) ### Prepare the release
diff --git a/tool/bots.sh b/tool/bots.sh index a55bb16..a9478fa 100755 --- a/tool/bots.sh +++ b/tool/bots.sh
@@ -79,7 +79,17 @@ pushd $DEVTOOLS_DIR/packages/devtools_app echo `pwd` -if [ "$BOT" = "main" ]; then +# TODO(https://github.com/dart-lang/sdk/issues/53992): we can put this back into +# the "main" bot once this issue is resolved. +if [ "$BOT" = "analyze" ]; then + + # Get packages + devtools_tool pub-get + + # Analyze the code + devtools_tool analyze + +elif [ "$BOT" = "main" ]; then # Verify that dart format has been run. echo "Checking formatting..." @@ -92,9 +102,6 @@ # Get packages devtools_tool pub-get - # Analyze the code - devtools_tool analyze - popd # Test the `devtools_app_shared`, `devtools_shared` and `devtools_extensions` package tests on the