Minor tidy up extracted from auto-reconnect change (#9589)
Some minor changes extracted from https://github.com/flutter/devtools/pull/9587, since that review got quite big and I want to simplify it a bit.
- Exclude nested SDK from being analyzed in VS Code
- Fix path in DTD task (it was correct for inside the `packages` folder but was moved to the root without updating)
- Update release notes + template to not say "general updates" in all sections (when only one of them was general)
diff --git a/.vscode/settings.json b/.vscode/settings.json
index 9e614ef..83e9f1f 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -2,4 +2,7 @@
// Set current working directory to devtools_app.
"terminal.integrated.cwd": "packages/devtools_app",
"dart.showTodos": false,
+ "dart.analysisExcludedFolders": [
+ "tool/flutter-sdk"
+ ]
}
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
index fe8f842..4102e21 100644
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -5,7 +5,7 @@
"label": "Start DTD on Port 8500",
"detail": "Starts a DTD instance running on port 8500",
"type": "shell",
- "command": "${workspaceFolder}/../tool/flutter-sdk/bin/cache/dart-sdk/bin/dart",
+ "command": "${workspaceFolder}/tool/flutter-sdk/bin/cache/dart-sdk/bin/dart",
"args": [
"tooling-daemon",
"--disable-service-auth-codes",
diff --git a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
index a4873ad..5e4353d 100644
--- a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
+++ b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
@@ -15,7 +15,7 @@
## General updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Inspector updates
@@ -24,11 +24,11 @@
## Performance updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## CPU profiler updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Memory updates
@@ -37,19 +37,19 @@
## Debugger updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Network profiler updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Logging updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## App size tool updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Deep links tool updates
@@ -61,15 +61,15 @@
## VS Code Sidebar updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## DevTools Extension updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Advanced developer mode updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Full commit history
diff --git a/packages/devtools_app/release_notes/helpers/release_notes_template.md b/packages/devtools_app/release_notes/helpers/release_notes_template.md
index afc1b15..63b3034 100644
--- a/packages/devtools_app/release_notes/helpers/release_notes_template.md
+++ b/packages/devtools_app/release_notes/helpers/release_notes_template.md
@@ -15,55 +15,55 @@
## General updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Inspector updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Performance updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## CPU profiler updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Memory updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Debugger updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Network profiler updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Logging updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## App size tool updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Deep links tool updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## VS Code Sidebar updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## DevTools Extension updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Advanced developer mode updates
-TODO: Remove this section if there are not any general updates.
+TODO: Remove this section if there are not any updates.
## Full commit history
diff --git a/tool/lib/commands/release_notes_helper.dart b/tool/lib/commands/release_notes_helper.dart
index 0f8e471..5c72087 100644
--- a/tool/lib/commands/release_notes_helper.dart
+++ b/tool/lib/commands/release_notes_helper.dart
@@ -208,7 +208,7 @@
// TODO(kenz): one nice polish task could be to remove sections that are
// empty (i.e. sections that have the line
- // "TODO: Remove this section if there are not any general updates.").
+ // "TODO: Remove this section if there are not any updates.").
final srcLines = rawLines.sublist(titleLineIndex);
final imageLineIndices = <int>{};
for (int i = 0; i < srcLines.length; i++) {
