Rename uses of whitelist to allowlist (#2089)
diff --git a/packages/devtools_app/lib/src/service_extensions.dart b/packages/devtools_app/lib/src/service_extensions.dart index b6e8b0c..725c027 100644 --- a/packages/devtools_app/lib/src/service_extensions.dart +++ b/packages/devtools_app/lib/src/service_extensions.dart
@@ -256,7 +256,7 @@ structuredErrors, ]; -final Map<String, ServiceExtensionDescription> serviceExtensionsWhitelist = +final Map<String, ServiceExtensionDescription> serviceExtensionsAllowlist = Map.fromIterable( _extensionDescriptions, key: (extension) => extension.extension,
diff --git a/packages/devtools_app/lib/src/service_manager.dart b/packages/devtools_app/lib/src/service_manager.dart index 26b1abb..01cad9e 100644 --- a/packages/devtools_app/lib/src/service_manager.dart +++ b/packages/devtools_app/lib/src/service_manager.dart
@@ -562,7 +562,7 @@ final String valueFromJson = event.json['extensionData']['value'].toString(); - final extension = extensions.serviceExtensionsWhitelist[name]; + final extension = extensions.serviceExtensionsAllowlist[name]; if (extension != null) { final dynamic value = _getExtensionValueFromJson(name, valueFromJson); @@ -586,7 +586,7 @@ dynamic _getExtensionValueFromJson(String name, String valueFromJson) { final expectedValueType = - extensions.serviceExtensionsWhitelist[name].values.first.runtimeType; + extensions.serviceExtensionsAllowlist[name].values.first.runtimeType; switch (expectedValueType) { case bool: return valueFromJson == 'true' ? true : false; @@ -691,11 +691,11 @@ } Future<void> _restoreExtensionFromDevice(String name) async { - if (!extensions.serviceExtensionsWhitelist.containsKey(name)) { + if (!extensions.serviceExtensionsAllowlist.containsKey(name)) { return; } final expectedValueType = - extensions.serviceExtensionsWhitelist[name].values.first.runtimeType; + extensions.serviceExtensionsAllowlist[name].values.first.runtimeType; try { final response = await _service.callServiceExtension( @@ -732,7 +732,7 @@ } Future<void> _maybeRestoreExtension(String name, dynamic value) async { - final extensionDescription = extensions.serviceExtensionsWhitelist[name]; + final extensionDescription = extensions.serviceExtensionsAllowlist[name]; if (extensionDescription is extensions.ToggleableServiceExtensionDescription) { if (value == extensionDescription.enabledValue) {
diff --git a/packages/devtools_app/test/support/mocks.dart b/packages/devtools_app/test/support/mocks.dart index 2fbffa3..06826e3 100644 --- a/packages/devtools_app/test/support/mocks.dart +++ b/packages/devtools_app/test/support/mocks.dart
@@ -404,7 +404,7 @@ final String name, String valueFromJson, ) async { - final extension = extensions.serviceExtensionsWhitelist[name]; + final extension = extensions.serviceExtensionsAllowlist[name]; if (extension != null) { final dynamic value = _getExtensionValueFromJson(name, valueFromJson); @@ -427,7 +427,7 @@ dynamic _getExtensionValueFromJson(String name, String valueFromJson) { final expectedValueType = - extensions.serviceExtensionsWhitelist[name].values.first.runtimeType; + extensions.serviceExtensionsAllowlist[name].values.first.runtimeType; switch (expectedValueType) { case bool: return valueFromJson == 'true' ? true : false; @@ -473,10 +473,10 @@ } Future<void> _restoreExtensionFromDevice(String name) async { - if (!extensions.serviceExtensionsWhitelist.containsKey(name)) { + if (!extensions.serviceExtensionsAllowlist.containsKey(name)) { return; } - final extensionDescription = extensions.serviceExtensionsWhitelist[name]; + final extensionDescription = extensions.serviceExtensionsAllowlist[name]; final value = extensionValueOnDevice[name]; if (extensionDescription is extensions.ToggleableServiceExtensionDescription) {