Fix comment posting from forks (#144)
* Fix comment posting from forks
* Rephrase current changelog
* Reformat changelog
diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml
index 222aea6..2e8d654 100644
--- a/.github/workflows/health.yaml
+++ b/.github/workflows/health.yaml
@@ -29,7 +29,7 @@
# uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
# with:
# sdk: beta
-# checks: "version changelog license coverage"
+# checks: "version,changelog,license,coverage"
on:
workflow_call:
@@ -43,7 +43,7 @@
required: false
type: string
checks:
- description: What to check for in the PR health check - any subset of "version changelog license"
+ description: What to check for in the PR health check - any subset of "version,changelog,license,coverage"
default: "version,changelog,license,coverage"
type: string
required: false
@@ -119,7 +119,7 @@
echo ${{ github.event.number }} > current_repo/output/issueNumber
- name: Upload folder with number and markdown
- uses: actions/upload-artifact@v2
+ uses: actions/upload-artifact@65d862660abb392b8c4a3d1195a2108db131dd05
with:
name: output
- path: output/
\ No newline at end of file
+ path: current_repo/output/
\ No newline at end of file
diff --git a/.github/workflows/post_summaries.yaml b/.github/workflows/post_summaries.yaml
index 032f7c4..1f6f56d 100644
--- a/.github/workflows/post_summaries.yaml
+++ b/.github/workflows/post_summaries.yaml
@@ -25,7 +25,7 @@
var artifacts = await github.rest.actions.listWorkflowRunArtifacts({
owner: context.repo.owner,
repo: context.repo.repo,
- run_id: ${{github.event.workflow_run.id }},
+ run_id: ${{ github.event.workflow_run.id }},
});
var matchArtifact = artifacts.data.artifacts.filter((artifact) => {
return artifact.name == "output"
@@ -37,7 +37,7 @@
archive_format: 'zip',
});
var fs = require('fs');
- fs.writeFileSync('${{github.workspace}}/comment.zip', Buffer.from(download.data));
+ fs.writeFileSync('${{ github.workspace }}/comment.zip', Buffer.from(download.data));
- run: unzip comment.zip
@@ -49,9 +49,9 @@
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
var fs = require('fs');
- var markdown = fs.readFileSync('./comment.md');
+ var markdown = fs.readFileSync('./comment.md', 'utf8');
if (fs.existsSync('./commentId')) {
- var comment_number = Number(fs.readFileSync('./commentId'));
+ var comment_number = Number(fs.readFileSync('./commentId', 'utf8'));
await github.rest.issues.updateComment({
owner: context.repo.owner,
@@ -61,7 +61,7 @@
});
}
else{
- var issue_number = Number(fs.readFileSync('./issueNumber'));
+ var issue_number = Number(fs.readFileSync('./issueNumber', 'utf8'));
await github.rest.issues.createComment({
owner: context.repo.owner,
diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md
index b44c21f..3b1a32d 100644
--- a/pkgs/firehose/CHANGELOG.md
+++ b/pkgs/firehose/CHANGELOG.md
@@ -1,7 +1,9 @@
## 0.3.24
-- Start fixing [#137](https://github.com/dart-lang/ecosystem/issues/137).
+
+- Fix [#137](https://github.com/dart-lang/ecosystem/issues/137).
## 0.3.23
+
- Tweak PR health workflow.
- Shorten some text in the markdown summary table.
