add more lints to package:dart_flutter_team_lints (#71)
* add more lints to package:dart_flutter_team_lints
* require dart 2.19.0
* regen mono_repo; update corpus for new lints
* generally require 2.19
* more mono_repo regenerate
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
index 50d57c5..df61916 100644
--- a/.github/workflows/dart.yml
+++ b/.github/workflows/dart.yml
@@ -39,26 +39,35 @@
- name: mono_repo self validate
run: dart pub global run mono_repo generate --validate
job_002:
- name: "analyze_and_format; Dart 2.17.0; PKGS: pkgs/dart_flutter_team_lints, pkgs/firehose; `dart analyze --fatal-infos .`"
+ name: "analyze_and_format; Dart 2.19.0; PKGS: pkgs/corpus, pkgs/dart_flutter_team_lints, pkgs/firehose; `dart analyze --fatal-infos .`"
runs-on: ubuntu-latest
steps:
- name: Cache Pub hosted dependencies
uses: actions/cache@627f0f41f6904a5b1efbaed9f96d9eb58e92e920
with:
path: "~/.pub-cache/hosted"
- key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:pkgs/dart_flutter_team_lints-pkgs/firehose;commands:analyze"
+ key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/corpus-pkgs/dart_flutter_team_lints-pkgs/firehose;commands:analyze"
restore-keys: |
- os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:pkgs/dart_flutter_team_lints-pkgs/firehose
- os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/corpus-pkgs/dart_flutter_team_lints-pkgs/firehose
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
os:ubuntu-latest;pub-cache-hosted
os:ubuntu-latest
- name: Setup Dart SDK
uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46
with:
- sdk: "2.17.0"
+ sdk: "2.19.0"
- id: checkout
name: Checkout repository
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
+ - id: pkgs_corpus_pub_upgrade
+ name: pkgs/corpus; dart pub upgrade
+ run: dart pub upgrade
+ if: "always() && steps.checkout.conclusion == 'success'"
+ working-directory: pkgs/corpus
+ - name: "pkgs/corpus; dart analyze --fatal-infos ."
+ run: dart analyze --fatal-infos .
+ if: "always() && steps.pkgs_corpus_pub_upgrade.conclusion == 'success'"
+ working-directory: pkgs/corpus
- id: pkgs_dart_flutter_team_lints_pub_upgrade
name: pkgs/dart_flutter_team_lints; dart pub upgrade
run: dart pub upgrade
@@ -80,38 +89,6 @@
needs:
- job_001
job_003:
- name: "analyze_and_format; Dart 2.18.0; PKG: pkgs/corpus; `dart analyze --fatal-infos .`"
- runs-on: ubuntu-latest
- steps:
- - name: Cache Pub hosted dependencies
- uses: actions/cache@627f0f41f6904a5b1efbaed9f96d9eb58e92e920
- with:
- path: "~/.pub-cache/hosted"
- key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:pkgs/corpus;commands:analyze"
- restore-keys: |
- os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:pkgs/corpus
- os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0
- os:ubuntu-latest;pub-cache-hosted
- os:ubuntu-latest
- - name: Setup Dart SDK
- uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46
- with:
- sdk: "2.18.0"
- - id: checkout
- name: Checkout repository
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
- - id: pkgs_corpus_pub_upgrade
- name: pkgs/corpus; dart pub upgrade
- run: dart pub upgrade
- if: "always() && steps.checkout.conclusion == 'success'"
- working-directory: pkgs/corpus
- - name: "pkgs/corpus; dart analyze --fatal-infos ."
- run: dart analyze --fatal-infos .
- if: "always() && steps.pkgs_corpus_pub_upgrade.conclusion == 'success'"
- working-directory: pkgs/corpus
- needs:
- - job_001
- job_004:
name: "analyze_and_format; Dart dev; PKGS: pkgs/corpus, pkgs/dart_flutter_team_lints, pkgs/firehose; `dart analyze --fatal-infos .`"
runs-on: ubuntu-latest
steps:
@@ -161,7 +138,7 @@
working-directory: pkgs/firehose
needs:
- job_001
- job_005:
+ job_004:
name: "analyze_and_format; Dart dev; PKGS: pkgs/corpus, pkgs/dart_flutter_team_lints, pkgs/firehose; `dart format --output=none --set-exit-if-changed .`"
runs-on: ubuntu-latest
steps:
@@ -211,96 +188,24 @@
working-directory: pkgs/firehose
needs:
- job_001
- job_006:
- name: "unit_test; Dart 2.17.0; PKG: pkgs/dart_flutter_team_lints; `dart test`"
+ job_005:
+ name: "unit_test; Dart 2.19.0; PKG: pkgs/corpus; `dart test`"
runs-on: ubuntu-latest
steps:
- name: Cache Pub hosted dependencies
uses: actions/cache@627f0f41f6904a5b1efbaed9f96d9eb58e92e920
with:
path: "~/.pub-cache/hosted"
- key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:pkgs/dart_flutter_team_lints;commands:test_1"
+ key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/corpus;commands:test_1"
restore-keys: |
- os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:pkgs/dart_flutter_team_lints
- os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/corpus
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
os:ubuntu-latest;pub-cache-hosted
os:ubuntu-latest
- name: Setup Dart SDK
uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46
with:
- sdk: "2.17.0"
- - id: checkout
- name: Checkout repository
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
- - id: pkgs_dart_flutter_team_lints_pub_upgrade
- name: pkgs/dart_flutter_team_lints; dart pub upgrade
- run: dart pub upgrade
- if: "always() && steps.checkout.conclusion == 'success'"
- working-directory: pkgs/dart_flutter_team_lints
- - name: pkgs/dart_flutter_team_lints; dart test
- run: dart test
- if: "always() && steps.pkgs_dart_flutter_team_lints_pub_upgrade.conclusion == 'success'"
- working-directory: pkgs/dart_flutter_team_lints
- needs:
- - job_001
- - job_002
- - job_003
- - job_004
- - job_005
- job_007:
- name: "unit_test; Dart 2.17.0; PKG: pkgs/firehose; `dart test`"
- runs-on: ubuntu-latest
- steps:
- - name: Cache Pub hosted dependencies
- uses: actions/cache@627f0f41f6904a5b1efbaed9f96d9eb58e92e920
- with:
- path: "~/.pub-cache/hosted"
- key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:pkgs/firehose;commands:test_1"
- restore-keys: |
- os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:pkgs/firehose
- os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0
- os:ubuntu-latest;pub-cache-hosted
- os:ubuntu-latest
- - name: Setup Dart SDK
- uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46
- with:
- sdk: "2.17.0"
- - id: checkout
- name: Checkout repository
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
- - id: pkgs_firehose_pub_upgrade
- name: pkgs/firehose; dart pub upgrade
- run: dart pub upgrade
- if: "always() && steps.checkout.conclusion == 'success'"
- working-directory: pkgs/firehose
- - name: pkgs/firehose; dart test
- run: dart test
- if: "always() && steps.pkgs_firehose_pub_upgrade.conclusion == 'success'"
- working-directory: pkgs/firehose
- needs:
- - job_001
- - job_002
- - job_003
- - job_004
- - job_005
- job_008:
- name: "unit_test; Dart 2.18.0; PKG: pkgs/corpus; `dart test`"
- runs-on: ubuntu-latest
- steps:
- - name: Cache Pub hosted dependencies
- uses: actions/cache@627f0f41f6904a5b1efbaed9f96d9eb58e92e920
- with:
- path: "~/.pub-cache/hosted"
- key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:pkgs/corpus;commands:test_1"
- restore-keys: |
- os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0;packages:pkgs/corpus
- os:ubuntu-latest;pub-cache-hosted;sdk:2.18.0
- os:ubuntu-latest;pub-cache-hosted
- os:ubuntu-latest
- - name: Setup Dart SDK
- uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46
- with:
- sdk: "2.18.0"
+ sdk: "2.19.0"
- id: checkout
name: Checkout repository
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
@@ -318,8 +223,77 @@
- job_002
- job_003
- job_004
- - job_005
- job_009:
+ job_006:
+ name: "unit_test; Dart 2.19.0; PKG: pkgs/dart_flutter_team_lints; `dart test`"
+ runs-on: ubuntu-latest
+ steps:
+ - name: Cache Pub hosted dependencies
+ uses: actions/cache@627f0f41f6904a5b1efbaed9f96d9eb58e92e920
+ with:
+ path: "~/.pub-cache/hosted"
+ key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/dart_flutter_team_lints;commands:test_1"
+ restore-keys: |
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/dart_flutter_team_lints
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
+ os:ubuntu-latest;pub-cache-hosted
+ os:ubuntu-latest
+ - name: Setup Dart SDK
+ uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46
+ with:
+ sdk: "2.19.0"
+ - id: checkout
+ name: Checkout repository
+ uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
+ - id: pkgs_dart_flutter_team_lints_pub_upgrade
+ name: pkgs/dart_flutter_team_lints; dart pub upgrade
+ run: dart pub upgrade
+ if: "always() && steps.checkout.conclusion == 'success'"
+ working-directory: pkgs/dart_flutter_team_lints
+ - name: pkgs/dart_flutter_team_lints; dart test
+ run: dart test
+ if: "always() && steps.pkgs_dart_flutter_team_lints_pub_upgrade.conclusion == 'success'"
+ working-directory: pkgs/dart_flutter_team_lints
+ needs:
+ - job_001
+ - job_002
+ - job_003
+ - job_004
+ job_007:
+ name: "unit_test; Dart 2.19.0; PKG: pkgs/firehose; `dart test`"
+ runs-on: ubuntu-latest
+ steps:
+ - name: Cache Pub hosted dependencies
+ uses: actions/cache@627f0f41f6904a5b1efbaed9f96d9eb58e92e920
+ with:
+ path: "~/.pub-cache/hosted"
+ key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/firehose;commands:test_1"
+ restore-keys: |
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:pkgs/firehose
+ os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
+ os:ubuntu-latest;pub-cache-hosted
+ os:ubuntu-latest
+ - name: Setup Dart SDK
+ uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46
+ with:
+ sdk: "2.19.0"
+ - id: checkout
+ name: Checkout repository
+ uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
+ - id: pkgs_firehose_pub_upgrade
+ name: pkgs/firehose; dart pub upgrade
+ run: dart pub upgrade
+ if: "always() && steps.checkout.conclusion == 'success'"
+ working-directory: pkgs/firehose
+ - name: pkgs/firehose; dart test
+ run: dart test
+ if: "always() && steps.pkgs_firehose_pub_upgrade.conclusion == 'success'"
+ working-directory: pkgs/firehose
+ needs:
+ - job_001
+ - job_002
+ - job_003
+ - job_004
+ job_008:
name: "unit_test; Dart dev; PKG: pkgs/corpus; `dart test`"
runs-on: ubuntu-latest
steps:
@@ -354,8 +328,7 @@
- job_002
- job_003
- job_004
- - job_005
- job_010:
+ job_009:
name: "unit_test; Dart dev; PKG: pkgs/dart_flutter_team_lints; `dart test`"
runs-on: ubuntu-latest
steps:
@@ -390,8 +363,7 @@
- job_002
- job_003
- job_004
- - job_005
- job_011:
+ job_010:
name: "unit_test; Dart dev; PKG: pkgs/firehose; `dart test`"
runs-on: ubuntu-latest
steps:
@@ -426,8 +398,7 @@
- job_002
- job_003
- job_004
- - job_005
- job_012:
+ job_011:
name: "analyze_format; Dart dev; PKG: pkgs/blast_repo; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`"
runs-on: ubuntu-latest
steps:
@@ -472,8 +443,7 @@
- job_008
- job_009
- job_010
- - job_011
- job_013:
+ job_012:
name: "test; Dart dev; PKG: pkgs/blast_repo; `dart test --test-randomize-ordering-seed=random`"
runs-on: ubuntu-latest
steps:
@@ -515,4 +485,3 @@
- job_009
- job_010
- job_011
- - job_012
diff --git a/pkgs/blast_repo/pubspec.yaml b/pkgs/blast_repo/pubspec.yaml
index 2b1fcf5..ddfcce2 100644
--- a/pkgs/blast_repo/pubspec.yaml
+++ b/pkgs/blast_repo/pubspec.yaml
@@ -3,7 +3,7 @@
publish_to: none
environment:
- sdk: ^2.18.0
+ sdk: ^2.19.0
dependencies:
args: ^2.3.1
diff --git a/pkgs/corpus/bin/deps.dart b/pkgs/corpus/bin/deps.dart
index be25c2d..c5ef3f7 100644
--- a/pkgs/corpus/bin/deps.dart
+++ b/pkgs/corpus/bin/deps.dart
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
/// Outputs information in CSV format for all the dependents of a given package.
+library;
import 'dart:io';
diff --git a/pkgs/corpus/pubspec.yaml b/pkgs/corpus/pubspec.yaml
index 901cd35..fe4124b 100644
--- a/pkgs/corpus/pubspec.yaml
+++ b/pkgs/corpus/pubspec.yaml
@@ -3,7 +3,7 @@
publish_to: none
environment:
- sdk: '>=2.18.0 <3.0.0'
+ sdk: '>=2.19.0 <3.0.0'
dependencies:
analyzer: ^5.0.0
diff --git a/pkgs/dart_flutter_team_lints/CHANGELOG.md b/pkgs/dart_flutter_team_lints/CHANGELOG.md
index 5eca24f..7258459 100644
--- a/pkgs/dart_flutter_team_lints/CHANGELOG.md
+++ b/pkgs/dart_flutter_team_lints/CHANGELOG.md
@@ -1,3 +1,15 @@
+## 1.0.0
+
+- Added `collection_methods_unrelated_type`.
+- Added `combinators_ordering`.
+- Added `dangling_library_doc_comments`.
+- Added `implicit_call_tearoffs`.
+- Added `library_annotations`.
+- Added `unnecessary_library_directive`.
+- Added `unreachable_from_main`.
+- Added `use_string_in_part_of_directives`.
+- Require Dart `2.19.0`.
+
## 0.1.0
- Turn on `strict-casts: true`.
diff --git a/pkgs/dart_flutter_team_lints/lib/analysis_options.yaml b/pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
index db88c26..11659ff 100644
--- a/pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
+++ b/pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
@@ -26,10 +26,12 @@
- avoid_shadowing_type_parameters
- avoid_types_as_parameter_names
- camel_case_extensions
+ - combinators_ordering
- curly_braces_in_flow_control_structures
- directives_ordering
- empty_catches
- file_names
+ - library_annotations
- lines_longer_than_80_chars
- omit_local_variable_types
- prefer_asserts_in_initializer_lists
@@ -39,20 +41,26 @@
- prefer_typing_uninitialized_variables
- sort_pub_dependencies
- unnecessary_lambdas
+ - unnecessary_library_directive
- unnecessary_overrides
- unnecessary_parenthesis
- unnecessary_statements
- use_is_even_rather_than_modulo
+ - use_string_in_part_of_directives
# correctness
- always_declare_return_types
- avoid_catching_errors
- avoid_dynamic_calls
- await_only_futures
+ - collection_methods_unrelated_type
+ - dangling_library_doc_comments
- hash_and_equals
+ - implicit_call_tearoffs
- no_duplicate_case_values
- only_throw_errors
- throw_in_finally
- type_annotate_public_apis
- unawaited_futures
+ - unreachable_from_main
- unrelated_type_equality_checks
diff --git a/pkgs/dart_flutter_team_lints/pubspec.yaml b/pkgs/dart_flutter_team_lints/pubspec.yaml
index 5f27503..dfba5ab 100644
--- a/pkgs/dart_flutter_team_lints/pubspec.yaml
+++ b/pkgs/dart_flutter_team_lints/pubspec.yaml
@@ -1,14 +1,15 @@
name: dart_flutter_team_lints
description: An analysis rule set used by the Dart and Flutter teams.
-version: 0.1.0
+version: 1.0.0
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints
environment:
- sdk: '>=2.17.0 <3.0.0'
+ sdk: '>=2.19.0 <3.0.0'
dependencies:
lints: ^2.0.0
dev_dependencies:
+ checks: ^0.2.0
test: ^1.0.0
yaml: ^3.0.0
diff --git a/pkgs/dart_flutter_team_lints/test/validate_test.dart b/pkgs/dart_flutter_team_lints/test/validate_test.dart
index 264e048..e25174a 100644
--- a/pkgs/dart_flutter_team_lints/test/validate_test.dart
+++ b/pkgs/dart_flutter_team_lints/test/validate_test.dart
@@ -4,6 +4,7 @@
import 'dart:io';
+import 'package:checks/checks.dart';
import 'package:test/test.dart';
import 'package:yaml/yaml.dart' as yaml;
@@ -16,16 +17,16 @@
test('well-formed', () {
var result = yaml.loadYaml(content);
- expect(result, isMap);
+ check(result).isA<Map>();
});
test('references recommended', () {
var result = yaml.loadYaml(content) as yaml.YamlMap;
- expect(result['include'], equals('package:lints/recommended.yaml'));
+ check(result['include']).equals('package:lints/recommended.yaml');
});
test('defines linter rules', () {
var result = yaml.loadYaml(content) as yaml.YamlMap;
- expect((result['linter'] as Map)['rules'], isNotEmpty);
+ check((result['linter'] as Map)['rules'] as List).isNotEmpty();
});
}
diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md
index c17c216..b90c173 100644
--- a/pkgs/firehose/CHANGELOG.md
+++ b/pkgs/firehose/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.3.14-dev
+
+- Require Dart `2.19.0`.
+
## 0.3.13
- Added the ability to specify the version of the SDK to use for publishing.
diff --git a/pkgs/firehose/pubspec.yaml b/pkgs/firehose/pubspec.yaml
index 4c0d40b..081edab 100644
--- a/pkgs/firehose/pubspec.yaml
+++ b/pkgs/firehose/pubspec.yaml
@@ -1,10 +1,10 @@
name: firehose
description: A tool to automate publishing of Pub packages from GitHub actions.
-version: 0.3.13
+version: 0.3.14-dev
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
environment:
- sdk: '>=2.17.0 <3.0.0'
+ sdk: '>=2.19.0 <3.0.0'
executables:
firehose: firehose
