commit ec15420b57e27da6ad0ea4c9a6c41d34b8be683f
author William Hesse <whesse@google.com> Wed Jan 22 14:03:10 2020 +0000
committer William Hesse <whesse@google.com> Wed Jan 22 14:03:10 2020 +0000
tree 7a8fcef45a1b810b113aad538d9fa1c0b8104e87
parent a9ba2ee5be6178c986c2c1c1dc9831c5f83a7323

[results feed] Add error checking for a missing try_build record

We have seen this error occur, and not yet found the root cause.
Provide better information if it occurs again.

Change-Id: Iec1ed37295ca408edaf62983ff7eb66b688811f0
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/132860
Reviewed-by: Jonas Termansen <sortie@google.com>

results_feed/lib/src/components/results_panel.dart

diff --git a/results_feed/lib/src/components/results_panel.dart b/results_feed/lib/src/components/results_panel.dart
index 2c6c253..587bbef 100644
--- a/results_feed/lib/src/components/results_panel.dart
+++ b/results_feed/lib/src/components/results_panel.dart
@@ -75,8 +75,15 @@
     RelativePosition.OffsetTopLeft
   ];
 
-  String buildbucketID(int patchset, String configuration) =>
-      builds[patchset][builders[configuration]].buildbucketID;
+  String buildbucketID(int patchset, String configuration) {
+    final result = builds[patchset][builders[configuration]].buildbucketID;
+    if (result == null) {
+      throw StateError(
+          "Try builder record missing for builder ${builders[configuration]} "
+          "on patchset $patchset of this CL");
+    }
+    return result;
+  }
 
   String approvalContent(Change change) =>
       change.approved ? formatting.checkmark : '';