commit c92f7417b2d6a0f916eba78c381988f6507f7696
author William Hesse <whesse@google.com> Thu Apr 23 15:47:17 2020 +0000
committer William Hesse <whesse@google.com> Thu Apr 23 15:47:17 2020 +0000
tree 34f4f0bb3b94a93a6f2d99e0d9c7eeb766da3274
parent 93242af419a5b0db485bbeb9f0c71eae5955c152

[cloud functions] Remove computation of active_failures for build

Change-Id: I5befc871052426232115bc09bb03cfd99bc66adf
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/144540
Reviewed-by: Alexander Thomas <athom@google.com>

functions/node/firestore.dart

diff --git a/functions/node/firestore.dart b/functions/node/firestore.dart
index 9edabc2..1fed023 100644
--- a/functions/node/firestore.dart
+++ b/functions/node/firestore.dart
@@ -22,8 +22,6 @@
 
   Future<void> addCommit(String id, Map<String, dynamic> data);
 
-  Future<List<String>> getConfigurations(String builder);
-
   Future<void> updateConfiguration(String configuration, String builder);
 
   Future<void> updateBuildInfo(String builder, int buildNumber, int index);

functions/node/firestore_impl.dart

diff --git a/functions/node/firestore_impl.dart b/functions/node/firestore_impl.dart
index 06d70a8..67ecf62 100644
--- a/functions/node/firestore_impl.dart
+++ b/functions/node/firestore_impl.dart
@@ -150,15 +150,6 @@
     await setDocument(firestore.document('commits/$id'), data);
   }
 
-  Future<List<String>> getConfigurations(String builder) async {
-    QuerySnapshot snapshot = await runQuery(
-        firestore
-            .collection('configurations')
-            .where('builder', isEqualTo: builder),
-        'configurations where builder == $builder');
-    return [for (final document in snapshot.documents) document.documentID];
-  }
-
   Future<void> updateConfiguration(String configuration, String builder) async {
     final record =
         await getDocument(firestore.document('configurations/$configuration'));
@@ -469,24 +460,6 @@
     // Compute activeFailures outside transaction, because it runs queries.
     // Because "completed" might be true inside transaction, but not now,
     // we must compute activeFailures always, not just on last chunk.
-    var activeFailures = false;
-    final configurations = await getConfigurations(builder);
-    for (final configuration in configurations) {
-      // Find out if there are any unapproved unfixed failures,
-      // which we call "active" failures, to give sticky redness.
-      final snapshot = await runQuery(
-          firestore
-              .collection('results')
-              .where('active_configurations', arrayContains: configuration)
-              .where('approved', isEqualTo: false)
-              .limit(1),
-          'results where active_configurations contains $configuration, '
-          'approved == false, limit 1');
-      if (snapshot.isNotEmpty) {
-        activeFailures = true;
-        break;
-      }
-    }
     Future<void> updateStatus(Transaction transaction) async {
       final snapshot = await transaction.get(document);
       documentsFetched++;
@@ -498,7 +471,6 @@
         'processed_chunks': processedChunks + 1,
         'success': (data['success'] ?? true) && success,
         if (completed) 'completed': true,
-        if (completed && activeFailures) 'active_failures': true
       });
       transaction.update(document, update);
       documentsWritten++;