| commit | bf3217f99418d3f2c635541ece4d318e1bc50080 | [log] [tgz] |
|---|---|---|
| author | William Hesse <whesse@google.com> | Wed Dec 18 11:55:43 2019 +0000 |
| committer | William Hesse <whesse@google.com> | Wed Dec 18 11:55:43 2019 +0000 |
| tree | 996fa1dd34dd7c2b55307ed63fd8e1ce70357e40 | |
| parent | 3133b1b87a81c5824548dfc070f8adf3340baba6 [diff] |
[results feed] Show only commits with changed results, by default Change-Id: I2b17c22bc54bf158fe9f3adc2b2c7bd4e36d9575 Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/128860 Reviewed-by: Alexander Thomas <athom@google.com>
diff --git a/results_feed/lib/src/model/comment.dart b/results_feed/lib/src/model/comment.dart index aeafdf5..40434b5 100644 --- a/results_feed/lib/src/model/comment.dart +++ b/results_feed/lib/src/model/comment.dart
@@ -54,7 +54,8 @@ review = document.get('review'), patchset = document.get('patchset'); - String approvedText() => approved ? 'approved' : ''; + String approvedText() => + (approved == null) ? "" : approved ? "approved" : "disapproved"; int compareTo(Object other) => created.compareTo((other as Comment).created); }
diff --git a/results_feed/lib/src/services/filter_service.dart b/results_feed/lib/src/services/filter_service.dart index d0d0f51..fa3de05 100644 --- a/results_feed/lib/src/services/filter_service.dart +++ b/results_feed/lib/src/services/filter_service.dart
@@ -67,7 +67,7 @@ return result; } - static const defaultShowAllCommits = true; + static const defaultShowAllCommits = false; static const defaultShowLatestFailures = false; static const defaultShowUnapprovedOnly = false; static const allConfigurationGroups = <String>[