[results feed] Add indent to test names, clean up styles
Change-Id: Ib150f8667b27affc9a80817df63e164b9611eb07
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/127121
Reviewed-by: Alexander Thomas <athom@google.com>
diff --git a/results_feed/lib/src/components/app_component.css b/results_feed/lib/src/components/app_component.css
index fd9c58f..474795e 100644
--- a/results_feed/lib/src/components/app_component.css
+++ b/results_feed/lib/src/components/app_component.css
@@ -1,3 +1,9 @@
+/**
+ * Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+
.material-header {
height: 64px;
position: fixed;
diff --git a/results_feed/lib/src/components/blamelist.css b/results_feed/lib/src/components/blamelist.css
index 643ccb6..f8c38ab 100644
--- a/results_feed/lib/src/components/blamelist.css
+++ b/results_feed/lib/src/components/blamelist.css
@@ -1,8 +1,9 @@
-/* Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-*/
+/**
+ * Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
-.commit { margin-bottom: 8px; }
+.commit { margin-bottom: 8px; display: flex; }
.comment-body { padding-left: 32px; }
span.nowrap { white-space: nowrap; }
\ No newline at end of file
diff --git a/results_feed/lib/src/components/blamelist_picker.dart b/results_feed/lib/src/components/blamelist_picker.dart
index d9bd82b..a741ff5 100644
--- a/results_feed/lib/src/components/blamelist_picker.dart
+++ b/results_feed/lib/src/components/blamelist_picker.dart
@@ -24,7 +24,7 @@
],
templateUrl: 'blamelist_picker.html',
styleUrls: ([
- 'commit_component.css',
+ 'blamelist.css',
'package:angular_components/css/mdc_web/card/mdc-card.scss.css'
]),
exports: [formattedDate, formattedEmail])
diff --git a/results_feed/lib/src/components/commit_component.css b/results_feed/lib/src/components/commit_component.css
new file mode 100644
index 0000000..2177799
--- /dev/null
+++ b/results_feed/lib/src/components/commit_component.css
@@ -0,0 +1,15 @@
+/**
+ * Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+
+material-button {text-align: center; clear: both; }
+material-input { width: 80% }
+
+.commit { margin: 12px; background-color: white; box-shadow: 8px 8px 5px lightgray; }
+.commit-panel { margin: 8px; }
+@media screen and (min-width: 992px) {
+ .commit-panel { width: 45%; float: left; }
+}
+.commit-bottom { clear: both; padding: 8px; }
diff --git a/results_feed/lib/src/components/commit_component.scss b/results_feed/lib/src/components/commit_component.scss
deleted file mode 100644
index 96bd305..0000000
--- a/results_feed/lib/src/components/commit_component.scss
+++ /dev/null
@@ -1,18 +0,0 @@
-// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-.result-checkbox { height: 9px }
-.failure { background-color:lightCoral; }
-.success { background-color:lightGreen; }
-.commit { margin: 12px; background-color: white; box-shadow: 8px 8px 5px lightgray; }
-dart-commit { padding: 8px * 2; }
-.commit-panel { margin: 8px; }
-@media screen and (min-width: 992px) {
- .commit-panel { width: 45%; float: left; }
-}
-.commit-bottom { clear: both; padding: 8px; }
-material-checkbox { height: 8px }
-.nonbreaking { white-space: nowrap; }
-material-button {text-align: center; clear: both; }
-material-input { width: 80% }
diff --git a/results_feed/lib/src/components/results.css b/results_feed/lib/src/components/results.css
new file mode 100644
index 0000000..5926294
--- /dev/null
+++ b/results_feed/lib/src/components/results.css
@@ -0,0 +1,13 @@
+/**
+ * Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+ * for details. All rights reserved. Use of this source code is governed by a
+ * BSD-style license that can be found in the LICENSE file.
+ */
+
+.failure { background-color:lightCoral; }
+.success { background-color:lightGreen; }
+
+.indent { margin-left: 16px; }
+span.nowrap { white-space: nowrap; }
+.pointer { cursor: pointer; }
+.result-checkbox { height: 9px }
diff --git a/results_feed/lib/src/components/results_panel.dart b/results_feed/lib/src/components/results_panel.dart
index 925061e..bade11d 100644
--- a/results_feed/lib/src/components/results_panel.dart
+++ b/results_feed/lib/src/components/results_panel.dart
@@ -33,7 +33,7 @@
providers: [popupBindings, tooltip.materialTooltipBindings],
templateUrl: 'results_panel.html',
styleUrls: ([
- 'commit_component.css',
+ 'results.css',
'package:angular_components/css/mdc_web/card/mdc-card.scss.css'
]))
class ResultsPanel {
diff --git a/results_feed/lib/src/components/results_panel.html b/results_feed/lib/src/components/results_panel.html
index c515397..fd49d27 100644
--- a/results_feed/lib/src/components/results_panel.html
+++ b/results_feed/lib/src/components/results_panel.html
@@ -22,13 +22,13 @@
</material-chips>
<div
*ngFor="let resultGroup of configurationGroup"
- style="margin-left: 16px">
+ class="indent">
<span [class]="resultGroup.first.resultStyle">
{{resultGroup.first.changesText}}
</span><br>
<span *ngFor="let change of resultGroup.take(resultLimit)"
tooltipTarget #logs="tooltipTarget"
- style="cursor: pointer">
+ class="indent pointer">
{{approvalContent(change)}}{{change.name}}<br>
<material-tooltip-card
*ngIf="range.length > 0"
@@ -48,7 +48,7 @@
<div
*ngIf="resultGroup.length > resultLimit"
(click)="resultLimit = resultGroup.length"
- style="cursor: pointer">
+ class="pointer">
⋮ {{resultGroup.length - resultLimit}} more changed results
</div>
</div>
diff --git a/results_feed/lib/src/components/results_selector_panel.dart b/results_feed/lib/src/components/results_selector_panel.dart
index 8d45338..4aa67b9 100644
--- a/results_feed/lib/src/components/results_selector_panel.dart
+++ b/results_feed/lib/src/components/results_selector_panel.dart
@@ -39,7 +39,7 @@
providers: [popupBindings, tooltip.materialTooltipBindings],
templateUrl: 'results_selector_panel.html',
styleUrls: ([
- 'commit_component.css',
+ 'results.css',
'package:angular_components/css/mdc_web/card/mdc-card.scss.css'
]))
class ResultsSelectorPanel {
diff --git a/results_feed/lib/src/components/results_selector_panel.html b/results_feed/lib/src/components/results_selector_panel.html
index 762ba52..27eb610 100644
--- a/results_feed/lib/src/components/results_selector_panel.html
+++ b/results_feed/lib/src/components/results_selector_panel.html
@@ -27,8 +27,8 @@
</material-tooltip-card>
</template>
</material-chips>
- <span *ngFor="let resultGroup of configurationGroup"
- style="margin-left: 16px">
+ <div *ngFor="let resultGroup of configurationGroup"
+ class="indent">
<material-checkbox
*ngIf="showResultGroupCheckbox(resultGroup)"
no-ink
@@ -39,12 +39,14 @@
<span [class]="resultGroup.first.resultStyle">
{{resultGroup.first.changesText}}
</span><br>
- <span class="nonbreaking" *ngFor="let change of resultGroup.take(resultLimit)"
- tooltipTarget
- #logs="tooltipTarget"
- style="cursor: pointer; margin-left: 16px; height: 16px">
+ <span
+ class="nowrap indent pointer"
+ *ngFor="let change of resultGroup.take(resultLimit)"
+ tooltipTarget
+ #logs="tooltipTarget">
<material-checkbox
*ngIf="showCheckbox(change)"
+ class="result-checkbox"
no-ink
[checked]="checked[change]"
(checkedChange)="onChange($event, change, resultGroup, configurationGroup)">
@@ -73,5 +75,5 @@
style="cursor: pointer">
⋮ {{resultGroup.length - resultLimit}} more changed results
</div>
- </span>
+ </div>
</div>
