commit 9a6f47ea63792c27eb2dbacf354db452d1201f0f
author William Hesse <whesse@google.com> Thu Sep 17 10:33:22 2020 +0000
committer William Hesse <whesse@google.com> Thu Sep 17 10:33:22 2020 +0000
tree be628ede705a7891912a5b6f9caa785dcc1fa069
parent 450c10f29c3a678001f9634e30b79fe24b544282

[current results ui] Remove the partial results indicator

Now that results are fetched sorted by test name, all visible
results are almost always complete, and the indicator is not helpful.

We might add a UI element showing summary counts of loaded results in
the future, which would help show if results are still loading.

Change-Id: I53923ee7b1486c44b0b6a4b4dacc9f0c38808836
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/163180
Reviewed-by: Karl Klose <karlklose@google.com>

current_results_ui/lib/query.dart

diff --git a/current_results_ui/lib/query.dart b/current_results_ui/lib/query.dart
index b8acd49..ee66120 100644
--- a/current_results_ui/lib/query.dart
+++ b/current_results_ui/lib/query.dart
@@ -25,7 +25,6 @@
   Map<String, Map<String, int>> counts = {};
   Map<String, Map<ChangeInResult, List<Result>>> grouped = {};
   int fetchedResultsCount = 0;
-  bool partialResults = true;
   bool get noQuery => filter.terms.isEmpty;
 
   QueryResults(this.filter);
@@ -44,7 +43,6 @@
     counts = {};
     grouped = {};
     fetchedResultsCount = 0;
-    partialResults = true;
 
     fetcher = fetchResults(filter).listen(onResults, onDone: onDone);
   }
@@ -72,7 +70,7 @@
   }
 
   void onDone() {
-    partialResults = false;
+    fetcher = null;
   }
 }
 

current_results_ui/lib/results.dart

diff --git a/current_results_ui/lib/results.dart b/current_results_ui/lib/results.dart
index 9d71693..e07dd46 100644
--- a/current_results_ui/lib/results.dart
+++ b/current_results_ui/lib/results.dart
@@ -41,9 +41,7 @@
         final name = filteredNames[index];
         final changeGroups = queryResults.grouped[name];
         final counts = queryResults.counts[name];
-        final partialResults = queryResults.partialResults;
-        return ExpandableResult(
-            name, changeGroups, counts, showAll, partialResults);
+        return ExpandableResult(name, changeGroups, counts, showAll);
       },
     );
   }
@@ -54,10 +52,8 @@
   final changeGroups;
   final counts;
   final bool showAll;
-  final bool partialResults;
 
-  ExpandableResult(this.name, this.changeGroups, this.counts, this.showAll,
-      this.partialResults)
+  ExpandableResult(this.name, this.changeGroups, this.counts, this.showAll)
       : super(key: Key(name));
 
   @override
@@ -107,7 +103,7 @@
                     scrollDirection: Axis.horizontal,
                     reverse: true,
                     child: SelectableText(
-                      widget.partialResults ? '$name (partial results)' : name,
+                      name,
                       style: TextStyle(fontSize: 16.0),
                     ),
                   ),