[cloud functions] Fix a type error created by refactoring
Change-Id: I978a29a739ba9902ac7a83dd6d45b07028f60fef
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/127282
Reviewed-by: Jonas Termansen <sortie@google.com>
diff --git a/functions/node/firestore.dart b/functions/node/firestore.dart
index 8bea531..e71e282 100644
--- a/functions/node/firestore.dart
+++ b/functions/node/firestore.dart
@@ -28,7 +28,7 @@
Future<void> storeReview(String review, Map<String, dynamic> data);
Future<void> storePatchset(
- String review, String patchset, Map<String, dynamic> data);
+ String review, int patchset, Map<String, dynamic> data);
Future<bool> reviewIsLanded(int review);
diff --git a/functions/node/firestore_impl.dart b/functions/node/firestore_impl.dart
index 4d1ae51..3e78b29 100644
--- a/functions/node/firestore_impl.dart
+++ b/functions/node/firestore_impl.dart
@@ -186,7 +186,7 @@
firestore.document('reviews/$review').setData(DocumentData.fromMap(data));
Future<void> storePatchset(
- String review, String patchset, Map<String, dynamic> data) =>
+ String review, int patchset, Map<String, dynamic> data) =>
firestore
.document('reviews/$review/patchsets/$patchset')
.setData(DocumentData.fromMap(data));
diff --git a/functions/node/gerrit_change.dart b/functions/node/gerrit_change.dart
index e9ab4ba..ec7a77a 100644
--- a/functions/node/gerrit_change.dart
+++ b/functions/node/gerrit_change.dart
@@ -43,9 +43,9 @@
// Add the patchset information to the patchsets subcollection.
final revisions = reviewInfo['revisions'].values.toList()
..sort((a, b) => (a['_number'] as int).compareTo(b['_number']));
- var patchsetGroupFirst;
+ int patchsetGroupFirst;
for (Map<String, dynamic> revision in revisions) {
- final number = revision['_number'];
+ int number = revision['_number'];
if (!trivialKinds.contains(revision['kind'])) {
patchsetGroupFirst = number;
}
