commit 2711386f1c86725f97c587010c00481b4c1975d0
author Karl Klose <karlklose@google.com> Thu Apr 29 08:58:26 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Thu Apr 29 08:58:26 2021 +0000
tree c0f49f28e391c379cc55feb2bd193a6b070b2760
parent 8d55820519ae51848891599cba842552105e730a

[current_results] Fix lints reported by 'pedantic'

Change-Id: I7bac566531c80299d7835c25c8a7c0df1a1a3808
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/197221
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>

current_results/bin/client.dart

diff --git a/current_results/bin/client.dart b/current_results/bin/client.dart
index 2b93baf..de7b3cf 100644
--- a/current_results/bin/client.dart
+++ b/current_results/bin/client.dart
@@ -24,6 +24,7 @@
 
 abstract class gRpcCommand extends Command {
   Future<void> runWithClient(QueryClient client);
+  @override
   Future<void> run() async {
     final channel = ClientChannel(globalResults['host'],
         port: int.parse(globalResults['port']),
@@ -50,9 +51,12 @@
         abbr: 'l', help: 'number of results to return');
     argParser.addOption('page', help: 'page token returned from previous call');
   }
+  @override
   String get name => 'getResults';
+  @override
   String get description => 'Send a GetResults gRPC request to the server';
 
+  @override
   Future<void> runWithClient(QueryClient client) async {
     final request = GetResultsRequest();
     request.filter = argResults['filter'] ?? '';
@@ -77,9 +81,12 @@
         help: 'number of test names starting with prefix to return');
   }
 
+  @override
   String get name => 'listTests';
+  @override
   String get description => 'Send a ListTests gRPC request to the server';
 
+  @override
   Future<void> runWithClient(QueryClient client) async {
     final query = ListTestsRequest()
       ..prefix = argResults['prefix']
@@ -90,9 +97,12 @@
 }
 
 class FetchCommand extends gRpcCommand {
+  @override
   String get name => 'fetch';
+  @override
   String get description => 'Send a Fetch gRPC request to the server';
 
+  @override
   Future<void> runWithClient(QueryClient client) async {
     final result = await client.fetch(Empty());
     print(jsonEncode(result.toProto3Json()));

current_results/lib/src/iterable.dart

diff --git a/current_results/lib/src/iterable.dart b/current_results/lib/src/iterable.dart
index ff458ed..834ac65 100644
--- a/current_results/lib/src/iterable.dart
+++ b/current_results/lib/src/iterable.dart
@@ -13,6 +13,7 @@
   bool _used = false;
   SingleUseIterable(this._iterator);
 
+  @override
   Iterator<T> get iterator {
     if (_used) throw StateError('SingleUseIterable.iterator called twice');
     _used = true;

current_results/lib/src/notifications.dart

diff --git a/current_results/lib/src/notifications.dart b/current_results/lib/src/notifications.dart
index dbdf839..878ab13 100644
--- a/current_results/lib/src/notifications.dart
+++ b/current_results/lib/src/notifications.dart
@@ -26,9 +26,6 @@
       ..subscription = subscription.name
       ..maxMessages = 1000);
     if (response.receivedMessages.isNotEmpty) {
-      final ackIds = [
-        for (final message in response.receivedMessages) message.ackId
-      ];
       await client.acknowledge(AcknowledgeRequest()
         ..subscription = subscription.name
         ..ackIds

current_results/lib/src/slice.dart

diff --git a/current_results/lib/src/slice.dart b/current_results/lib/src/slice.dart
index c6cc1f6..7e5e8ef 100644
--- a/current_results/lib/src/slice.dart
+++ b/current_results/lib/src/slice.dart
@@ -91,8 +91,9 @@
       } else if (compare == 0) {
         i++;
         j++;
-      } else
+      } else {
         break;
+      }
     }
     if (j == sorted.length) return names;
 
@@ -124,7 +125,7 @@
         query.pageToken.isEmpty ? null : PageStart.parse(query.pageToken);
     final filterTerms =
         query.filter.split(',').map((s) => s.trim()).where((s) => s.isNotEmpty);
-    final configurationSet = Set<String>();
+    final configurationSet = <String>{};
     final testPrefixes = <String>[];
     for (final prefix in filterTerms) {
       final matchingConfigurations = _stored.keys

current_results/test/iterable_test.dart

diff --git a/current_results/test/iterable_test.dart b/current_results/test/iterable_test.dart
index 974c4b9..4bc7dc3 100644
--- a/current_results/test/iterable_test.dart
+++ b/current_results/test/iterable_test.dart
@@ -72,7 +72,7 @@
     expect(merge(empty, b, xField), b);
   });
 
-  test("Iterable from Iterator", () {
+  test('Iterable from Iterator', () {
     final a = [
       1,
       2,
@@ -87,7 +87,9 @@
     final m = {'x': 1, 'y': 2};
     expect(m.keys.iterator.iterable, ['x', 'y']);
     Iterable<Map<String, int>> unbounded() sync* {
-      for (;;) yield m;
+      for (;;) {
+        yield m;
+      }
     }
 
     expect(unbounded().iterator.iterable.take(2), [m, m]);