update core and recommended from the recent review (dart-lang/lints#136)
* update core ad recommended from the recent review
* unnecessary_constructor_name was already in the set
diff --git a/pkgs/lints/CHANGELOG.md b/pkgs/lints/CHANGELOG.md
index 9d8d3ee..54f7038 100644
--- a/pkgs/lints/CHANGELOG.md
+++ b/pkgs/lints/CHANGELOG.md
@@ -1,6 +1,13 @@
-## 2.1.2-wip
+## 3.0.0-wip
-- Add 'has quick-fix' checkboxes to the package's readme.
+- Added to core.yaml:
+ - `collection_methods_unrelated_type`
+ - `implicit_call_tearoffs`
+ - `use_string_in_part_of_directives`
+- Removed from core.yaml:
+ - `iterable_contains_unrelated_type`
+ - `list_remove_unrelated_type`
+- Add info about which lints have quick fixs to the package's readme.
## 2.1.1
diff --git a/pkgs/lints/README.md b/pkgs/lints/README.md
index 2dfe1be..f917ba5 100644
--- a/pkgs/lints/README.md
+++ b/pkgs/lints/README.md
@@ -109,13 +109,13 @@
| [`await_only_futures`](https://dart.dev/lints/await_only_futures) | Await only futures. | ✅ |
| [`camel_case_extensions`](https://dart.dev/lints/camel_case_extensions) | Name extensions using UpperCamelCase. | |
| [`camel_case_types`](https://dart.dev/lints/camel_case_types) | Name types using UpperCamelCase. | |
+| [`collection_methods_unrelated_type`](https://dart.dev/lints/collection_methods_unrelated_type) | Invocation of various collection methods with arguments of unrelated types. | |
| [`curly_braces_in_flow_control_structures`](https://dart.dev/lints/curly_braces_in_flow_control_structures) | DO use curly braces for all flow control structures. | ✅ |
| [`depend_on_referenced_packages`](https://dart.dev/lints/depend_on_referenced_packages) | Depend on referenced packages. | |
| [`empty_catches`](https://dart.dev/lints/empty_catches) | Avoid empty catch blocks. | ✅ |
| [`file_names`](https://dart.dev/lints/file_names) | Name source files using `lowercase_with_underscores`. | |
| [`hash_and_equals`](https://dart.dev/lints/hash_and_equals) | Always override `hashCode` if overriding `==`. | ✅ |
-| [`iterable_contains_unrelated_type`](https://dart.dev/lints/iterable_contains_unrelated_type) | Invocation of Iterable<E>.contains with references of unrelated types. | |
-| [`list_remove_unrelated_type`](https://dart.dev/lints/list_remove_unrelated_type) | Invocation of `remove` with references of unrelated types. | |
+| [`implicit_call_tearoffs`](https://dart.dev/lints/implicit_call_tearoffs) | Explicitly tear-off `call` methods when using an object as a Function. | ✅ |
| [`no_duplicate_case_values`](https://dart.dev/lints/no_duplicate_case_values) | Don't use more than one case with same value. | ✅ |
| [`non_constant_identifier_names`](https://dart.dev/lints/non_constant_identifier_names) | Name non-constant identifiers using lowerCamelCase. | ✅ |
| [`null_check_on_nullable_type_parameter`](https://dart.dev/lints/null_check_on_nullable_type_parameter) | Don't use null check on a potentially nullable type parameter. | ✅ |
@@ -128,6 +128,7 @@
| [`provide_deprecation_message`](https://dart.dev/lints/provide_deprecation_message) | Provide a deprecation message, via @Deprecated("message"). | |
| [`unnecessary_overrides`](https://dart.dev/lints/unnecessary_overrides) | Don't override a method to do a super method invocation with the same parameters. | ✅ |
| [`unrelated_type_equality_checks`](https://dart.dev/lints/unrelated_type_equality_checks) | Equality operator `==` invocation with references of unrelated types. | |
+| [`use_string_in_part_of_directives`](https://dart.dev/lints/use_string_in_part_of_directives) | Use string in part of directives. | ✅ |
| [`valid_regexps`](https://dart.dev/lints/valid_regexps) | Use valid regular expression syntax. | |
| [`void_checks`](https://dart.dev/lints/void_checks) | Don't assign to void. | |
<!-- core -->
diff --git a/pkgs/lints/lib/core.yaml b/pkgs/lints/lib/core.yaml
index ec6fff7..a04ccf4 100644
--- a/pkgs/lints/lib/core.yaml
+++ b/pkgs/lints/lib/core.yaml
@@ -13,13 +13,13 @@
- await_only_futures
- camel_case_extensions
- camel_case_types
+ - collection_methods_unrelated_type
- curly_braces_in_flow_control_structures
- depend_on_referenced_packages
- empty_catches
- file_names
- hash_and_equals
- - iterable_contains_unrelated_type
- - list_remove_unrelated_type
+ - implicit_call_tearoffs
- no_duplicate_case_values
- non_constant_identifier_names
- null_check_on_nullable_type_parameter
@@ -32,5 +32,6 @@
- provide_deprecation_message
- unnecessary_overrides
- unrelated_type_equality_checks
+ - use_string_in_part_of_directives
- valid_regexps
- void_checks
diff --git a/pkgs/lints/pubspec.yaml b/pkgs/lints/pubspec.yaml
index 121dbd6..476869a 100644
--- a/pkgs/lints/pubspec.yaml
+++ b/pkgs/lints/pubspec.yaml
@@ -1,5 +1,5 @@
name: lints
-version: 2.1.2-wip
+version: 3.0.0-wip
description: >
Official Dart lint rules. Defines the 'core' and 'recommended' set of lints
suggested by the Dart team.
diff --git a/pkgs/lints/tool/rules.json b/pkgs/lints/tool/rules.json
index c96bd46..5cfc4c3 100644
--- a/pkgs/lints/tool/rules.json
+++ b/pkgs/lints/tool/rules.json
@@ -152,7 +152,7 @@
{
"name": "no_wildcard_variable_uses",
"description": "Don't use wildcard parameters or variables.",
- "fixStatus": "unregistered"
+ "fixStatus": "needsEvaluation"
},
{
"name": "prefer_relative_imports",
@@ -182,7 +182,7 @@
{
"name": "unrelated_type_equality_checks",
"description": "Equality operator `==` invocation with references of unrelated types.",
- "fixStatus": "noFix"
+ "fixStatus": "unregistered"
},
{
"name": "unsafe_html",