Update for repo best practices (#14)
- Use `pub.dev` links over `dardocs.org`.
- In example, follow `package:pedantic` style for function typed
argument.
- Drop unused author field from pubspec.
- Use a simpler constraint on `package:meta` since the SDK constraint
already prevents us from picking up older versions.
diff --git a/.travis.yml b/.travis.yml
index 412ec44..50f4a33 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,14 +5,18 @@
- 2.1.1
dart_task:
- - test
+ - test: -p vm,chrome
matrix:
include:
- dart: dev
- dart_task: dartanalyzer
- - dart: dev
dart_task: dartfmt
+ - dart: dev
+ dart_task:
+ dartanalyzer: --fatal-lints --fatal-warnings .
+ - dart: 2.1.1
+ dart_task:
+ dartanalyzer: --fatal-warnings .
# Only building master means that we don't run two builds for each pull request.
branches:
diff --git a/README.md b/README.md
index fd4a131..b847f76 100644
--- a/README.md
+++ b/README.md
@@ -4,8 +4,8 @@
default top-level [`clock`][]'s notion can be swapped out to reliably test
timing-dependent code.
-[`Clock`]: https://www.dartdocs.org/documentation/clock/latest/clock/Clock-class.html
-[`clock`]: https://www.dartdocs.org/documentation/clock/latest/clock/clock.html
+[`Clock`]: https://pub.dev/documentation/clock/latest/clock/Clock-class.html
+[`clock`]: https://pub.dev/documentation/clock/latest/clock/clock.html
For example, you can use `clock` in your libraries like this:
@@ -14,7 +14,7 @@
import 'package:clock/clock.dart';
/// Runs [callback] and prints how long it took.
-T runWithTiming<T>(T callback()) {
+T runWithTiming<T>(T Function() callback) {
var stopwatch = clock.stopwatch()..start();
var result = callback();
print('It took ${stopwatch.elapsed}!');
diff --git a/pubspec.yaml b/pubspec.yaml
index 275e43d..bfb1e06 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,14 +1,13 @@
name: clock
version: 1.0.2-dev
description: A fakeable wrapper for dart:core clock APIs
-author: Dart Team <misc@dartlang.org>
homepage: https://github.com/dart-lang/clock
environment:
sdk: '>=2.1.1 <3.0.0'
dependencies:
- meta: '>=0.9.0 <2.0.0'
+ meta: ^1.0.0
dev_dependencies:
test: ^1.0.0
diff --git a/test/stopwatch_test.dart b/test/stopwatch_test.dart
index 16720f1..d8e905d 100644
--- a/test/stopwatch_test.dart
+++ b/test/stopwatch_test.dart
@@ -165,5 +165,7 @@
});
});
});
+ }, onPlatform: {
+ 'js': const Skip('Web does not have enough precision'),
});
}
