commit 80886150a5e6c58006c8ae5a6c2aa7108638e2a9
author Jacob MacDonald <jakemac@google.com> Mon Oct 04 07:45:59 2021 -0700
committer GitHub <noreply@github.com> Mon Oct 04 07:45:59 2021 -0700
tree d2ec1ff459fab56247ec4552dd8886713d6d1607
parent e660b9c927e701e1757bf059681c291ab7a84de7

update some StreamController apis to Future<void> from Future<dynamic> (#198)

This is probably technically breaking for some cases - but it doesn't look to be breaking for anything at all internally, so I think in practice it is not breaking. Finishing up a global presubmit now with all the changes (but already did one with a subset).

WDYT?

CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 815c523..aabfb36 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,4 @@
-## 2.9.0
+## 2.9.0-dev
 
 * Add `StreamExtensions.firstOrNull`.
 
@@ -6,6 +6,9 @@
 
 * Add a `CancelableOperation.race()` static method.
 
+* Update `StreamGroup` methods that return a `Future<dynamic>` today to return
+  a `Future<void>` instead.
+
 ## 2.8.2
 
 * Deprecate `EventSinkBase`, `StreamSinkBase`, `IOSinkBase`.

lib/src/stream_group.dart

diff --git a/lib/src/stream_group.dart b/lib/src/stream_group.dart
index 51e43b4..514c3a4 100644
--- a/lib/src/stream_group.dart
+++ b/lib/src/stream_group.dart
@@ -137,7 +137,7 @@
   ///
   /// Throws a [StateError] if this group is closed.
   @override
-  Future? add(Stream<T> stream) {
+  Future<void>? add(Stream<T> stream) {
     if (_closed) {
       throw StateError("Can't add a Stream to a closed StreamGroup.");
     }
@@ -167,7 +167,7 @@
   ///
   /// If [stream]'s subscription is canceled, this returns
   /// [StreamSubscription.cancel]'s return value. Otherwise, it returns `null`.
-  Future? remove(Stream<T> stream) {
+  Future<void>? remove(Stream<T> stream) {
     var subscription = _subscriptions.remove(stream);
     var future = subscription?.cancel();
 
@@ -226,7 +226,7 @@
   /// A callback called when [stream] is canceled.
   ///
   /// This is only called for single-subscription groups.
-  Future? _onCancel() {
+  Future<void>? _onCancel() {
     _state = _StreamGroupState.canceled;
 
     var futures = _subscriptions.entries
@@ -287,7 +287,7 @@
   ///
   /// Returns a [Future] that completes once [stream] has actually been closed.
   @override
-  Future close() {
+  Future<void> close() {
     if (_closed) return _controller.done;
 
     _closed = true;