commit b947357168336150588f60fab41d67fda59cd532
author Srujan Gaddam <58529443+srujzs@users.noreply.github.com> Fri Aug 15 14:07:06 2025 -0700
committer GitHub <noreply@github.com> Fri Aug 15 14:07:06 2025 -0700
tree 5ac827f6f6e33458039ea506aeee2764b84122bc
parent c0492f1b40b591710cd8359d6f142ea6ff315985

[dwds] Fix bug where no-op hot restart doesn't cancel a subscription and publish 25.0.1 (#2668)

In hot restart, we wait for all sources to be parsed before continuing
to create the isolate. In order to do so, we listen on parsed sources
by registering a subscription. In the case where we have no sources
to restart, we don't cancel the subscription. This results in an issue
where on the next hot restart that contains changes, the old
subscription is triggered, potentially completing an already completed
completer. Instead, we should always cancel the subscription. Hot reload
code is changed as well to do the same.

Additional checks are added to check if the completer is completed
before we complete again. While this is not needed for this issue,
it is possible other sources can be downloaded by the app, which may
trigger the function in the listener, which could potentially try and
complete the completed completer.

Tests are added for both hot restart and hot reload to check that
alternating empty hot restarts and non-empty hot restarts work.