tree be29b66e75429c16fef822e480c77de8b4f647c4
parent df096a9718e41f6883e683f177376a0cfd1b604c
author Ömer Sinan Ağacan <omeragacan@gmail.com> 1702115258 +0100
committer GitHub <noreply@github.com> 1702115258 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJldDe6CRBK7hj4Ov3rIwAAo94IAFvJLrpg4+5h4XWZZMTTrc9q
 yK56d4gTGjVUTYV8lFAd+k+5u3ttxFWcVYmtE/ZALenERYBS+saX6/Uuj/afd8m+
 uu1wI7veMJGOBXahUVitySHGSUak3Ynli6sLRFYNCgiCUesLr+P8kvEQkY76OoqO
 1eAK1hnYDbYUl5x0lT9AkezeqSc3O4b0obTDc8A//pmwpBagTQFEuOh/9kLBlmqm
 moGeEQXkB10COo6IKWwUGoIJcMQ9m+eCmGxmM9PuV9YSDvCuh11BhIcqB8d31vly
 xgBNOSJlvtPyDf/6naeRquVof8DqMzGhMaKDkU2SO0j0nqsEtVBErE/Ut7oCfJ8=
 =rHW8
 -----END PGP SIGNATURE-----
 

Fix JS value to Dart conversion when receiving from a web socket (#298)

`MessageEvent` is a `package:web` type and `data` field is a JS value of type
`JSAny?`.

The receiving end of the `sink` is here:
https://github.com/dart-lang/sdk/blob/26107a319a7503deafee404e3462644a873e2920/pkg/vm_service/lib/src/vm_service.dart#L1795

This code currently does not expect to see JS objects, so passing a `JSAny?` to
the sink breaks it.

The fix should be in the generating end rather than the receiving end: `JSAny?`
is supposed to be an unboxed value, not a boxed Dart value. In an ideal world we
shouldn't be able to pass it as a Dart object. So we call `dartify` and convert
it to a Dart object.

This fixes DevTools when compiled to Wasm.

Thanks to @eyebrowsoffire and @mkustermann for help with debugging.

Co-authored-by: Kevin Moore <kevmoo@google.com>